From 8b07dc5cb8c259e8e51e2e2a81d9f03284b62cf1 Mon Sep 17 00:00:00 2001 From: Luke Shumaker Date: Sun, 13 Aug 2017 11:15:55 -0600 Subject: buildTabbedChartUi(): use `ph` as the iterator for placeholders, rather than `el` I was really confused; I expect `el` to be a DOM node. --- jarmon/jarmon.js | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/jarmon/jarmon.js b/jarmon/jarmon.js index 7be4f16..5f8d854 100644 --- a/jarmon/jarmon.js +++ b/jarmon/jarmon.js @@ -1194,15 +1194,17 @@ jarmon.buildTabbedChartUi = function ($chartTemplate, chartRecipes, var ti = new jarmon.TabbedInterface($tabTemplate, tabRecipes); var charts = jQuery.map( + // As a reminder, TabbedInterface#placeholders is an array of + // `["placeholder-name", jQuery-placeholder]` pairs. ti.placeholders, - function(el, i) { + function(ph, i) { var chart = new jarmon.Chart( - $chartTemplate.clone().appendTo(el[1]), - chartRecipes[el[0]], + $chartTemplate.clone().appendTo(ph[1]), + chartRecipes[ph[0]], serialDownloader ); - $('input[name=chart_edit]', el[1][0]).live( + $('input[name=chart_edit]', ph[1][0]).live( 'click', {chart: chart}, function(e) { @@ -1212,7 +1214,7 @@ jarmon.buildTabbedChartUi = function ($chartTemplate, chartRecipes, } ); - $('input[name=chart_delete]', el[1][0]).live( + $('input[name=chart_delete]', ph[1][0]).live( 'click', {chart: chart}, function(e) { -- cgit v1.2.3