diff options
| author | Dan McGee <dan@archlinux.org> | 2013-04-16 22:12:01 -0500 |
|---|---|---|
| committer | Dan McGee <dan@archlinux.org> | 2013-04-16 22:12:01 -0500 |
| commit | b7b24740640e24883cd17fd683e1d465fbb343f8 (patch) | |
| tree | 0a8a4fdf23f3a3b7f0551e859c36c23e3afe212f /devel | |
| parent | 31d39e75eea7fb6cdf3bb8bfd8b490d45de04ee9 (diff) | |
Various minor code cleanups and fixesrelease_2013-04-16
Most of these were suggested by PyCharm, and include everything from
little syntax issues and other bad smells to dead or bad code.
Signed-off-by: Dan McGee <dan@archlinux.org>
Diffstat (limited to 'devel')
| -rw-r--r-- | devel/management/commands/pgp_import.py | 1 | ||||
| -rw-r--r-- | devel/models.py | 1 | ||||
| -rw-r--r-- | devel/utils.py | 2 | ||||
| -rw-r--r-- | devel/views.py | 2 |
4 files changed, 3 insertions, 3 deletions
diff --git a/devel/management/commands/pgp_import.py b/devel/management/commands/pgp_import.py index 10e6cfcb..b1f29d77 100644 --- a/devel/management/commands/pgp_import.py +++ b/devel/management/commands/pgp_import.py @@ -95,6 +95,7 @@ def parse_keydata(data): # parse all of the output from our successful GPG command logger.info("parsing command output") + node = None for line in data.split('\n'): parts = line.split(':') if parts[0] == 'pub': diff --git a/devel/models.py b/devel/models.py index 67de40a6..4354e0f2 100644 --- a/devel/models.py +++ b/devel/models.py @@ -4,7 +4,6 @@ import pytz from django.db import models from django.db.models.signals import pre_save from django.contrib.auth.models import User -from django.utils.timezone import now from django_countries import CountryField from .fields import PGPKeyField diff --git a/devel/utils.py b/devel/utils.py index e8e3a6c4..340841f5 100644 --- a/devel/utils.py +++ b/devel/utils.py @@ -131,7 +131,7 @@ class UserFinder(object): self.username_email, self.user_name) for matcher in find_methods: user = matcher(name, email) - if user != None: + if user is not None: break self.cache[userstring] = user diff --git a/devel/views.py b/devel/views.py index 61c1e568..4258ea7f 100644 --- a/devel/views.py +++ b/devel/views.py @@ -34,7 +34,7 @@ from .utils import get_annotated_maintainers @login_required def index(request): '''the developer dashboard''' - if(request.user.is_authenticated()): + if request.user.is_authenticated(): inner_q = PackageRelation.objects.filter(user=request.user) else: inner_q = PackageRelation.objects.none() |