diff options
author | Dan McGee <dan@archlinux.org> | 2010-08-28 11:37:39 -0500 |
---|---|---|
committer | Dan McGee <dan@archlinux.org> | 2010-08-28 11:41:19 -0500 |
commit | d57696c8013d78f017972ae72efeeb441c954cb2 (patch) | |
tree | 5e9d9a70cda9a40b56dec08a1caf5b1e3e36edee /packages/views.py | |
parent | 7dcdb0a31519c038e25436b49a60b9e54a41372b (diff) |
PyLint suggested cleanups
We had a bunch of extra imports, non-conventional variable names, spacing
issues, etc. that were relatively low-hanging fruit to clean up. Fix them
and make the code a bit cleaner in the process.
Signed-off-by: Dan McGee <dan@archlinux.org>
Diffstat (limited to 'packages/views.py')
-rw-r--r-- | packages/views.py | 29 |
1 files changed, 15 insertions, 14 deletions
diff --git a/packages/views.py b/packages/views.py index 4fd34edf..2fe515c5 100644 --- a/packages/views.py +++ b/packages/views.py @@ -20,20 +20,20 @@ from main.models import Package, PackageFile from main.models import Arch, Repo, Signoff from main.models import MirrorUrl from main.utils import make_choice -from .models import PackageGroup, PackageRelation +from .models import PackageRelation from .utils import get_group_info, get_differences_info def opensearch(request): if request.is_secure(): - d = "https://%s" % request.META['HTTP_HOST'] + domain = "https://%s" % request.META['HTTP_HOST'] else: - d = "http://%s" % request.META['HTTP_HOST'] + domain = "http://%s" % request.META['HTTP_HOST'] response = HttpResponse(mimetype='application/opensearchdescription+xml') - t = loader.get_template('packages/opensearch.xml') - c = Context({ - 'domain': d, + template = loader.get_template('packages/opensearch.xml') + ctx = Context({ + 'domain': domain, }) - response.write(t.render(c)) + response.write(template.render(ctx)) return response @permission_required('main.change_package') @@ -54,11 +54,11 @@ def update(request): for pkg in pkgs: maints = pkg.maintainers if mode == 'adopt' and request.user not in maints: - pr = PackageRelation(pkgbase=pkg.pkgbase, + prel = PackageRelation(pkgbase=pkg.pkgbase, user=request.user, type=PackageRelation.MAINTAINER) count += 1 - pr.save() + prel.save() elif mode == 'disown' and request.user in maints: rels = PackageRelation.objects.filter(pkgbase=pkg.pkgbase, user=request.user) @@ -86,9 +86,9 @@ def details(request, name='', repo='', arch=''): arch.lower(), repo.title(), name)) def groups(request): - groups = get_group_info() + grps = get_group_info() return render_to_response('packages/groups.html', - RequestContext(request, {'groups': groups})) + RequestContext(request, {'groups': grps})) def group_details(request, arch, name): arch = get_object_or_404(Arch, name=arch) @@ -157,7 +157,7 @@ class PackageSearchForm(forms.Form): def search(request, page=None): current_query = '?' - limit=50 + limit = 50 packages = Package.objects.select_related('arch', 'repo') if request.GET: @@ -224,11 +224,12 @@ def search(request, page=None): def files(request, name='', repo='', arch=''): pkg = get_object_or_404(Package, pkgname=name, repo__name__iexact=repo, arch__name=arch) - files = PackageFile.objects.filter(pkg=pkg).order_by('path') + fileslist = PackageFile.objects.filter(pkg=pkg).order_by('path') template = 'packages/files.html' if request.is_ajax(): template = 'packages/files-list.html' - return render_to_response(template, RequestContext(request, {'pkg':pkg,'files':files})) + return render_to_response(template, RequestContext(request, + {'pkg':pkg, 'files':fileslist})) @permission_required('main.change_package') def unflag(request, name='', repo='', arch=''): |