From 3d40da381cccfb1e1b74becb9076e816f76c6f02 Mon Sep 17 00:00:00 2001 From: Dusty Phillips Date: Fri, 27 Jun 2008 21:15:34 -0400 Subject: refactor package cleaning to be duplicate sensitive --- todolists/views.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) (limited to 'todolists') diff --git a/todolists/views.py b/todolists/views.py index 127fd8b8..52987356 100644 --- a/todolists/views.py +++ b/todolists/views.py @@ -23,12 +23,11 @@ class TodoListForm(forms.Form): widget=forms.Textarea(attrs={'rows': '20', 'cols': '60'})) def clean_packages(self): - packages = [] - for p in self.clean_data['packages'].split("\n"): - for pkg in Package.objects.filter( - pkgname=p.strip()).order_by('arch').distinct(): - packages .append(pkg) - + package_names = [s.strip() for s in + self.clean_data['packages'].split("\n")] + package_names = set(package_names) + packages = Package.objects.filter( + pkgname__in=package_names).order_by('arch') return packages -- cgit v1.2.3-54-g00ecf