From cdc456c8b7c6e3eb4b11d668fb9c6e9bdec7230e Mon Sep 17 00:00:00 2001 From: Luke Shumaker Date: Thu, 20 Apr 2017 23:05:01 -0400 Subject: Don't use subshells in local/export/declare commands. Only make this change in places where it shouldn't make a difference, and something weird has to be going on for the subshell to fail. This is on par with checking the return value of malloc. We don't need tests for each of these failure cases. --- src/abslibre-tools/librerelease | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'src/abslibre-tools/librerelease') diff --git a/src/abslibre-tools/librerelease b/src/abslibre-tools/librerelease index 6d5651d..b8eb0e3 100755 --- a/src/abslibre-tools/librerelease +++ b/src/abslibre-tools/librerelease @@ -5,7 +5,7 @@ # Copyright (C) 2010-2012 Joshua Ismael Haase Hernández (xihh) # Copyright (C) 2010-2013 Nicolás Reynolds # Copyright (C) 2013 Michał Masłowski -# Copyright (C) 2013-2014 Luke Shumaker +# Copyright (C) 2013-2014, 2017 Luke Shumaker # # For just the create_signature() function: # Copyright (C) 2006-2013 Pacman Development Team @@ -191,7 +191,8 @@ clean() { lock 8 "${WORKDIR}/staging.lock" \ 'Waiting for an exclusive lock on the staging directory' - local file_list="$(mktemp -t ${0##*/}.XXXXXXXXXX)" + local file_list + file_list="$(mktemp -t "${0##*/}.XXXXXXXXXX")" trap "$(printf 'rm -f -- %q' "$file_list")" EXIT list0_files > "$file_list" -- cgit v1.2.3-54-g00ecf