The comment at the bottom of hackers_watch.go was wrong; fix the race.

The actual determinant was this race

        main        worker
        -------------------
        Close()     Read()
        Exit()

If Read() returned between when Close() happened and when Exit() happened,
then the code ran.

It doesn't *really* matter if the code runs, but for predictability, set up
a wait group to have Close() block until the worker exits.

1 files changed, 1 insertions, 5 deletions

diff --git a/src/nshd/hackers_git/hackers_watch.go b/src/nshd/hackers_git/hackers_watch.go
index 87c856d..9592dab 100644
--- a/src/nshd/hackers_git/hackers_watch.go
+++ b/src/nshd/hackers_git/hackers_watch.go
@@ -181,9 +181,5 @@ func (o *Hackers) worker() {
 			}
 		}
 	}
-	// This happens only sometimes--depending on if the main
-	// goroutine or this goroutine is killed by os.Exit first;
-	// this happens if the main goroutine calls inotify.Close()
-	// before this groutine is killed.
-	logger.Info("Stopping hackers.git inotify watcher")
+	logger.Info("Stopped hackers.git inotify watcher")
 }