|
There's still a condition that could be a race with fd-reuse, if one
goroutine is calling inotify.{AddWatch,RmWatch,Read}(); another
goroutine is calling inotify.Close(), and several things happen between
loadFd() running and the add_watch/rm_watch/read syscall launching:
- syscall.Close() returns
- syscall.Open() reuses the filedescriptor
A B
syscall(loadFd()) inotify.Close(); syscall.Open()
----------------------------------------------------------
loadFd()
syscall.Close()
syscall.Open()
syscall()
Given that Read() can't be allowed to block Close() from running, I'm not
sure there's a way to fix this.
|