diff options
Diffstat (limited to 'includes/actions/CreditsAction.php')
-rw-r--r-- | includes/actions/CreditsAction.php | 51 |
1 files changed, 31 insertions, 20 deletions
diff --git a/includes/actions/CreditsAction.php b/includes/actions/CreditsAction.php index 0a2bf306..e064aab4 100644 --- a/includes/actions/CreditsAction.php +++ b/includes/actions/CreditsAction.php @@ -39,7 +39,7 @@ class CreditsAction extends FormlessAction { /** * This is largely cadged from PageHistory::history * - * @return String HTML + * @return string HTML */ public function onView() { wfProfileIn( __METHOD__ ); @@ -58,9 +58,9 @@ class CreditsAction extends FormlessAction { /** * Get a list of contributors * - * @param int $cnt maximum list of contributors to show - * @param bool $showIfMax whether to contributors if there more than $cnt - * @return String: html + * @param int $cnt Maximum list of contributors to show + * @param bool $showIfMax Whether to contributors if there more than $cnt + * @return string Html */ public function getCredits( $cnt, $showIfMax = true ) { wfProfileIn( __METHOD__ ); @@ -74,13 +74,14 @@ class CreditsAction extends FormlessAction { } wfProfileOut( __METHOD__ ); + return $s; } /** * Get the last author with the last modification time * @param Page $page - * @return String HTML + * @return string HTML */ protected function getAuthor( Page $page ) { $user = User::newFromName( $page->getUserText(), false ); @@ -94,19 +95,29 @@ class CreditsAction extends FormlessAction { $d = ''; $t = ''; } + return $this->msg( 'lastmodifiedatby', $d, $t )->rawParams( $this->userLink( $user ) )->params( $user->getName() )->escaped(); } /** + * Whether we can display the user's real name (not a hidden pref) + * + * @since 1.24 + * @return bool + */ + protected function canShowRealUserName() { + $hiddenPrefs = $this->context->getConfig()->get( 'HiddenPrefs' ); + return !in_array( 'realname', $hiddenPrefs ); + } + + /** * Get a list of contributors of $article - * @param int $cnt maximum list of contributors to show - * @param bool $showIfMax whether to contributors if there more than $cnt - * @return String: html + * @param int $cnt Maximum list of contributors to show + * @param bool $showIfMax Whether to contributors if there more than $cnt + * @return string Html */ protected function getContributors( $cnt, $showIfMax ) { - global $wgHiddenPrefs; - $contributors = $this->page->getContributors(); $others_link = false; @@ -125,11 +136,12 @@ class CreditsAction extends FormlessAction { $anon_ips = array(); # Sift for real versus user names + /** @var $user User */ foreach ( $contributors as $user ) { $cnt--; if ( $user->isLoggedIn() ) { $link = $this->link( $user ); - if ( !in_array( 'realname', $wgHiddenPrefs ) && $user->getRealName() ) { + if ( $this->canShowRealUserName() && $user->getRealName() ) { $real_names[] = $link; } else { $user_names[] = $link; @@ -175,6 +187,7 @@ class CreditsAction extends FormlessAction { } $count = count( $fulllist ); + # "Based on work by ..." return $count ? $this->msg( 'othercontribs' )->rawParams( @@ -184,12 +197,11 @@ class CreditsAction extends FormlessAction { /** * Get a link to $user's user page - * @param $user User object - * @return String: html + * @param User $user + * @return string Html */ protected function link( User $user ) { - global $wgHiddenPrefs; - if ( !in_array( 'realname', $wgHiddenPrefs ) && !$user->isAnon() ) { + if ( $this->canShowRealUserName() && !$user->isAnon() ) { $real = $user->getRealName(); } else { $real = false; @@ -204,16 +216,15 @@ class CreditsAction extends FormlessAction { /** * Get a link to $user's user page - * @param $user User object - * @return String: html + * @param User $user + * @return string Html */ protected function userLink( User $user ) { $link = $this->link( $user ); if ( $user->isAnon() ) { return $this->msg( 'anonuser' )->rawParams( $link )->parse(); } else { - global $wgHiddenPrefs; - if ( !in_array( 'realname', $wgHiddenPrefs ) && $user->getRealName() ) { + if ( $this->canShowRealUserName() && $user->getRealName() ) { return $link; } else { return $this->msg( 'siteuser' )->rawParams( $link )->params( $user->getName() )->escaped(); @@ -223,7 +234,7 @@ class CreditsAction extends FormlessAction { /** * Get a link to action=credits of $article page - * @return String: HTML link + * @return string HTML link */ protected function othersLink() { return Linker::linkKnown( |