diff options
Diffstat (limited to 'includes/filerepo/RepoGroup.php')
-rw-r--r-- | includes/filerepo/RepoGroup.php | 36 |
1 files changed, 19 insertions, 17 deletions
diff --git a/includes/filerepo/RepoGroup.php b/includes/filerepo/RepoGroup.php index f9e57599..b2b9477a 100644 --- a/includes/filerepo/RepoGroup.php +++ b/includes/filerepo/RepoGroup.php @@ -79,8 +79,8 @@ class RepoGroup { /** * Construct a group of file repositories. * - * @param $localInfo array Associative array for local repo's info - * @param $foreignInfo Array of repository info arrays. + * @param array $localInfo Associative array for local repo's info + * @param array $foreignInfo of repository info arrays. * Each info array is an associative array with the 'class' member * giving the class name. The entire array is passed to the repository * constructor as the first parameter. @@ -96,7 +96,7 @@ class RepoGroup { * You can also use wfFindFile() to do this. * * @param $title Title|string Title object or string - * @param $options array Associative array of options: + * @param array $options Associative array of options: * time: requested time for an archived image, or false for the * current version. An image object will be returned which was * created at the specified time. @@ -131,7 +131,7 @@ class RepoGroup { $time = isset( $options['time'] ) ? $options['time'] : ''; $dbkey = $title->getDBkey(); if ( isset( $this->cache[$dbkey][$time] ) ) { - wfDebug( __METHOD__.": got File:$dbkey from process cache\n" ); + wfDebug( __METHOD__ . ": got File:$dbkey from process cache\n" ); # Move it to the end of the list so that we can delete the LRU entry later $this->pingCache( $dbkey ); # Return the entry @@ -209,7 +209,7 @@ class RepoGroup { } $redir = $this->localRepo->checkRedirect( $title ); - if( $redir ) { + if ( $redir ) { return $redir; } foreach ( $this->foreignRepos as $repo ) { @@ -225,8 +225,8 @@ class RepoGroup { * Find an instance of the file with this key, created at the specified time * Returns false if the file does not exist. * - * @param $hash String base 36 SHA-1 hash - * @param $options array Option array, same as findFile() + * @param string $hash base 36 SHA-1 hash + * @param array $options Option array, same as findFile() * @return File object or false if it is not found */ function findFileFromKey( $hash, $options = array() ) { @@ -238,7 +238,9 @@ class RepoGroup { if ( !$file ) { foreach ( $this->foreignRepos as $repo ) { $file = $repo->findFileFromKey( $hash, $options ); - if ( $file ) break; + if ( $file ) { + break; + } } } return $file; @@ -247,7 +249,7 @@ class RepoGroup { /** * Find all instances of files with this key * - * @param $hash String base 36 SHA-1 hash + * @param string $hash base 36 SHA-1 hash * @return Array of File objects */ function findBySha1( $hash ) { @@ -266,7 +268,7 @@ class RepoGroup { /** * Find all instances of files with this keys * - * @param $hashes Array base 36 SHA-1 hashes + * @param array $hashes base 36 SHA-1 hashes * @return Array of array of File objects */ function findBySha1s( array $hashes ) { @@ -279,7 +281,7 @@ class RepoGroup { $result = array_merge_recursive( $result, $repo->findBySha1s( $hashes ) ); } //sort the merged (and presorted) sublist of each hash - foreach( $result as $hash => $files ) { + foreach ( $result as $hash => $files ) { usort( $result[$hash], 'File::compare' ); } return $result; @@ -335,13 +337,13 @@ class RepoGroup { * first parameter. * * @param $callback Callback: the function to call - * @param $params Array: optional additional parameters to pass to the function + * @param array $params optional additional parameters to pass to the function * @return bool */ function forEachForeignRepo( $callback, $params = array() ) { - foreach( $this->foreignRepos as $repo ) { + foreach ( $this->foreignRepos as $repo ) { $args = array_merge( array( $repo ), $params ); - if( call_user_func_array( $callback, $args ) ) { + if ( call_user_func_array( $callback, $args ) ) { return true; } } @@ -388,12 +390,12 @@ class RepoGroup { */ function splitVirtualUrl( $url ) { if ( substr( $url, 0, 9 ) != 'mwrepo://' ) { - throw new MWException( __METHOD__.': unknown protocol' ); + throw new MWException( __METHOD__ . ': unknown protocol' ); } $bits = explode( '/', substr( $url, 9 ), 3 ); if ( count( $bits ) != 3 ) { - throw new MWException( __METHOD__.": invalid mwrepo URL: $url" ); + throw new MWException( __METHOD__ . ": invalid mwrepo URL: $url" ); } return $bits; } @@ -433,7 +435,7 @@ class RepoGroup { while ( count( $this->cache ) >= self::MAX_CACHE_SIZE ) { reset( $this->cache ); $key = key( $this->cache ); - wfDebug( __METHOD__.": evicting $key\n" ); + wfDebug( __METHOD__ . ": evicting $key\n" ); unset( $this->cache[$key] ); } } |