From 222b01f5169f1c7e69762e0e8904c24f78f71882 Mon Sep 17 00:00:00 2001 From: Pierre Schmitz Date: Wed, 28 Jul 2010 11:52:48 +0200 Subject: update to MediaWiki 1.16.0 --- includes/Status.php | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) (limited to 'includes/Status.php') diff --git a/includes/Status.php b/includes/Status.php index 185ea6e5..a07a4b81 100644 --- a/includes/Status.php +++ b/includes/Status.php @@ -84,6 +84,13 @@ class Status { $this->ok = false; } + /** + * Sanitize the callback parameter on wakeup, to avoid arbitrary execution. + */ + function __wakeup() { + $this->cleanCallback = false; + } + protected function cleanParams( $params ) { if ( !$this->cleanCallback ) { return $params; @@ -152,7 +159,7 @@ class Status { if ( $longContext ) { $s = wfMsgNoTrans( $longContext, $s ); } elseif ( $shortContext ) { - $s = wfMsgNoTrans( $shortContext, "\n* $s\n" ); + $s = wfMsgNoTrans( $shortContext, "\n$s\n" ); } } return $s; @@ -170,12 +177,15 @@ class Status { $this->successCount += $other->successCount; $this->failCount += $other->failCount; } - + function getErrorsArray() { $result = array(); foreach ( $this->errors as $error ) { if ( $error['type'] == 'error' ) - $result[] = $error['message']; + if( $error['params'] ) + $result[] = array_merge( array( $error['message'] ), $error['params'] ); + else + $result[] = $error['message']; } return $result; } -- cgit v1.2.3-54-g00ecf