1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
|
<?php
/**
* Transaction profiling for contention
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
* http://www.gnu.org/copyleft/gpl.html
*
* @file
* @ingroup Profiler
* @author Aaron Schulz
*/
use Psr\Log\LoggerInterface;
use Psr\Log\LoggerAwareInterface;
use Psr\Log\NullLogger;
/**
* Helper class that detects high-contention DB queries via profiling calls
*
* This class is meant to work with a DatabaseBase object, which manages queries
*
* @since 1.24
*/
class TransactionProfiler implements LoggerAwareInterface {
/** @var float Seconds */
protected $dbLockThreshold = 3.0;
/** @var float Seconds */
protected $eventThreshold = .25;
/** @var array transaction ID => (write start time, list of DBs involved) */
protected $dbTrxHoldingLocks = array();
/** @var array transaction ID => list of (query name, start time, end time) */
protected $dbTrxMethodTimes = array();
/** @var array */
protected $hits = array(
'writes' => 0,
'queries' => 0,
'conns' => 0,
'masterConns' => 0
);
/** @var array */
protected $expect = array(
'writes' => INF,
'queries' => INF,
'conns' => INF,
'masterConns' => INF,
'maxAffected' => INF,
'readQueryTime' => INF,
'writeQueryTime' => INF
);
/** @var array */
protected $expectBy = array();
/**
* @var LoggerInterface
*/
private $logger;
public function __construct() {
$this->setLogger( new NullLogger() );
}
public function setLogger( LoggerInterface $logger ) {
$this->logger = $logger;
}
/**
* Set performance expectations
*
* With conflicting expectations, the most narrow ones will be used
*
* @param string $event (writes,queries,conns,mConns)
* @param integer $value Maximum count of the event
* @param string $fname Caller
* @since 1.25
*/
public function setExpectation( $event, $value, $fname ) {
$this->expect[$event] = isset( $this->expect[$event] )
? min( $this->expect[$event], $value )
: $value;
if ( $this->expect[$event] == $value ) {
$this->expectBy[$event] = $fname;
}
}
/**
* Set multiple performance expectations
*
* With conflicting expectations, the most narrow ones will be used
*
* @param array $expects Map of (event => limit)
* @param $fname
* @since 1.26
*/
public function setExpectations( array $expects, $fname ) {
foreach ( $expects as $event => $value ) {
$this->setExpectation( $event, $value, $fname );
}
}
/**
* Reset performance expectations and hit counters
*
* @since 1.25
*/
public function resetExpectations() {
foreach ( $this->hits as &$val ) {
$val = 0;
}
unset( $val );
foreach ( $this->expect as &$val ) {
$val = INF;
}
unset( $val );
$this->expectBy = array();
}
/**
* Mark a DB as having been connected to with a new handle
*
* Note that there can be multiple connections to a single DB.
*
* @param string $server DB server
* @param string $db DB name
* @param bool $isMaster
*/
public function recordConnection( $server, $db, $isMaster ) {
// Report when too many connections happen...
if ( $this->hits['conns']++ == $this->expect['conns'] ) {
$this->reportExpectationViolated( 'conns', "[connect to $server ($db)]" );
}
if ( $isMaster && $this->hits['masterConns']++ == $this->expect['masterConns'] ) {
$this->reportExpectationViolated( 'masterConns', "[connect to $server ($db)]" );
}
}
/**
* Mark a DB as in a transaction with one or more writes pending
*
* Note that there can be multiple connections to a single DB.
*
* @param string $server DB server
* @param string $db DB name
* @param string $id ID string of transaction
*/
public function transactionWritingIn( $server, $db, $id ) {
$name = "{$server} ({$db}) (TRX#$id)";
if ( isset( $this->dbTrxHoldingLocks[$name] ) ) {
$this->logger->info( "Nested transaction for '$name' - out of sync." );
}
$this->dbTrxHoldingLocks[$name] = array(
'start' => microtime( true ),
'conns' => array(), // all connections involved
);
$this->dbTrxMethodTimes[$name] = array();
foreach ( $this->dbTrxHoldingLocks as $name => &$info ) {
// Track all DBs in transactions for this transaction
$info['conns'][$name] = 1;
}
}
/**
* Register the name and time of a method for slow DB trx detection
*
* This assumes that all queries are synchronous (non-overlapping)
*
* @param string $query Function name or generalized SQL
* @param float $sTime Starting UNIX wall time
* @param bool $isWrite Whether this is a write query
* @param integer $n Number of affected rows
*/
public function recordQueryCompletion( $query, $sTime, $isWrite = false, $n = 0 ) {
$eTime = microtime( true );
$elapsed = ( $eTime - $sTime );
if ( $isWrite && $n > $this->expect['maxAffected'] ) {
$this->logger->info( "Query affected $n row(s):\n" . $query . "\n" .
wfBacktrace( true ) );
}
// Report when too many writes/queries happen...
if ( $this->hits['queries']++ == $this->expect['queries'] ) {
$this->reportExpectationViolated( 'queries', $query );
}
if ( $isWrite && $this->hits['writes']++ == $this->expect['writes'] ) {
$this->reportExpectationViolated( 'writes', $query );
}
// Report slow queries...
if ( !$isWrite && $elapsed > $this->expect['readQueryTime'] ) {
$this->reportExpectationViolated( 'readQueryTime', $query );
}
if ( $isWrite && $elapsed > $this->expect['writeQueryTime'] ) {
$this->reportExpectationViolated( 'writeQueryTime', $query );
}
if ( !$this->dbTrxHoldingLocks ) {
// Short-circuit
return;
} elseif ( !$isWrite && $elapsed < $this->eventThreshold ) {
// Not an important query nor slow enough
return;
}
foreach ( $this->dbTrxHoldingLocks as $name => $info ) {
$lastQuery = end( $this->dbTrxMethodTimes[$name] );
if ( $lastQuery ) {
// Additional query in the trx...
$lastEnd = $lastQuery[2];
if ( $sTime >= $lastEnd ) { // sanity check
if ( ( $sTime - $lastEnd ) > $this->eventThreshold ) {
// Add an entry representing the time spent doing non-queries
$this->dbTrxMethodTimes[$name][] = array( '...delay...', $lastEnd, $sTime );
}
$this->dbTrxMethodTimes[$name][] = array( $query, $sTime, $eTime );
}
} else {
// First query in the trx...
if ( $sTime >= $info['start'] ) { // sanity check
$this->dbTrxMethodTimes[$name][] = array( $query, $sTime, $eTime );
}
}
}
}
/**
* Mark a DB as no longer in a transaction
*
* This will check if locks are possibly held for longer than
* needed and log any affected transactions to a special DB log.
* Note that there can be multiple connections to a single DB.
*
* @param string $server DB server
* @param string $db DB name
* @param string $id ID string of transaction
* @param float $writeTime Time spent in write queries
*/
public function transactionWritingOut( $server, $db, $id, $writeTime = 0.0 ) {
$name = "{$server} ({$db}) (TRX#$id)";
if ( !isset( $this->dbTrxMethodTimes[$name] ) ) {
$this->logger->info( "Detected no transaction for '$name' - out of sync." );
return;
}
$slow = false;
// Warn if too much time was spend writing...
if ( $writeTime > $this->expect['writeQueryTime'] ) {
$this->reportExpectationViolated( 'writeQueryTime',
"[transaction $id writes to {$server} ({$db})]" );
$slow = true;
}
// Fill in the last non-query period...
$lastQuery = end( $this->dbTrxMethodTimes[$name] );
if ( $lastQuery ) {
$now = microtime( true );
$lastEnd = $lastQuery[2];
if ( ( $now - $lastEnd ) > $this->eventThreshold ) {
$this->dbTrxMethodTimes[$name][] = array( '...delay...', $lastEnd, $now );
}
}
// Check for any slow queries or non-query periods...
foreach ( $this->dbTrxMethodTimes[$name] as $info ) {
$elapsed = ( $info[2] - $info[1] );
if ( $elapsed >= $this->dbLockThreshold ) {
$slow = true;
break;
}
}
if ( $slow ) {
$dbs = implode( ', ', array_keys( $this->dbTrxHoldingLocks[$name]['conns'] ) );
$msg = "Sub-optimal transaction on DB(s) [{$dbs}]:\n";
foreach ( $this->dbTrxMethodTimes[$name] as $i => $info ) {
list( $query, $sTime, $end ) = $info;
$msg .= sprintf( "%d\t%.6f\t%s\n", $i, ( $end - $sTime ), $query );
}
$this->logger->info( $msg );
}
unset( $this->dbTrxHoldingLocks[$name] );
unset( $this->dbTrxMethodTimes[$name] );
}
/**
* @param string $expect
* @param string $query
*/
protected function reportExpectationViolated( $expect, $query ) {
global $wgRequest;
$n = $this->expect[$expect];
$by = $this->expectBy[$expect];
$this->logger->info(
"[{$wgRequest->getMethod()}] Expectation ($expect <= $n) by $by not met:\n$query\n" .
wfBacktrace( true )
);
}
}
|