diff options
| author | Lukas Fleischer <archlinux@cryptocrack.de> | 2012-02-19 04:49:54 +0100 |
|---|---|---|
| committer | Lukas Fleischer <archlinux@cryptocrack.de> | 2012-02-19 05:21:48 +0100 |
| commit | 19789c3f759f4162a2eaa4ccc0b6fe0df51957ca (patch) | |
| tree | 3d1dd05e7c975d7c166a50ed389838513ced0844 | |
| parent | 6f6904db3fa4921abc92b936dbc50bfdea0cb225 (diff) | |
Escape all output strings in the header and footer
Escape each output string using htmlspecialchars(). These aren't
exploitable; it's still better to escape them properly.
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
| -rw-r--r-- | web/template/footer.php | 2 | ||||
| -rw-r--r-- | web/template/header.php | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/web/template/footer.php b/web/template/footer.php index 435de5c..0948f68 100644 --- a/web/template/footer.php +++ b/web/template/footer.php @@ -2,7 +2,7 @@ <!-- End of main content --> <?php if ($ver) { - echo "<div class=\"pgbox version\">$ver</div>"; + echo "<div class=\"pgbox version\">" . htmlspecialchars($ver) . "</div>"; } ?> </body> diff --git a/web/template/header.php b/web/template/header.php index 578fcb9..8749dae 100644 --- a/web/template/header.php +++ b/web/template/header.php @@ -2,7 +2,7 @@ <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> <html xmlns="http://www.w3.org/1999/xhtml" - xml:lang="<?php print "$LANG\" lang=\"$LANG"; ?>"> + xml:lang="<?php print htmlspecialchars($LANG, ENT_QUOTES) ?>" lang="<?php print htmlspecialchars($LANG, ENT_QUOTES) ?>"> <head> <title>AUR (<?php print htmlspecialchars($LANG); ?>)<?php if ($title != "") { print " - " . htmlspecialchars($title); } ?></title> <link rel='stylesheet' type='text/css' href='css/fonts.css' /> @@ -52,8 +52,8 @@ reset($SUPPORTED_LANGS); foreach ($SUPPORTED_LANGS as $lang => $lang_name) { print '<a href="' . htmlspecialchars($_SERVER["PHP_SELF"], ENT_QUOTES) - ."?setlang=$lang\" title=\"$lang_name\">" - . strtolower($lang) . "</a>\n"; + ."?setlang=" . htmlspecialchars($lang, ENT_QUOTES) . "\" title=\"" . htmlspecialchars($lang_name, ENT_QUOTES) . "\">" + . htmlspecialchars(strtolower($lang)) . "</a>\n"; } ?> </div> |