summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLukas Fleischer <lfleischer@archlinux.org>2016-08-22 08:12:07 +0200
committerLukas Fleischer <lfleischer@archlinux.org>2016-08-22 08:16:26 +0200
commit29625e074472b6546e7433e9b72a3b907abd06ff (patch)
tree27930a2d1944e2e8ccff57080254365240963b17
parentc7616311810ae4817fc4b0585b5ef335e6273dbb (diff)
git-update: Close cursor before closing database
When using SQLite as backend, we need to close the cursor before closing the database to avoid the following error: sqlite3.OperationalError: unable to close due to unfinalized statements or unfinished backups Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
-rwxr-xr-xgit-interface/git-update.py1
-rwxr-xr-xgit-interface/test/t0003-update.sh2
2 files changed, 2 insertions, 1 deletions
diff --git a/git-interface/git-update.py b/git-interface/git-update.py
index 40d834d..50938c3 100755
--- a/git-interface/git-update.py
+++ b/git-interface/git-update.py
@@ -402,4 +402,5 @@ repo.create_reference('refs/namespaces/' + pkgbase + '/HEAD', sha1_new, True)
update_notify(conn, user, pkgbase_id)
# Close the database.
+cur.close()
conn.close()
diff --git a/git-interface/test/t0003-update.sh b/git-interface/test/t0003-update.sh
index ec830ba..4a45779 100755
--- a/git-interface/test/t0003-update.sh
+++ b/git-interface/test/t0003-update.sh
@@ -368,7 +368,7 @@ test_expect_success 'Pushing a blacklisted package.' '
test_cmp expected actual
'
-test_expect_failure 'Pushing a blacklisted package as Trusted User.' '
+test_expect_success 'Pushing a blacklisted package as Trusted User.' '
old=$(git -C aur.git rev-parse HEAD) &&
test_when_finished "git -C aur.git reset --hard $old" &&
echo "pkgname = forbidden" >>aur.git/.SRCINFO &&