diff options
author | canyonknight <canyonknight@gmail.com> | 2012-06-23 14:40:11 -0400 |
---|---|---|
committer | Lukas Fleischer <archlinux@cryptocrack.de> | 2012-06-24 10:59:23 +0200 |
commit | 2c93f0a98f0f6380fd07ea17fd16afa2c6e4925b (patch) | |
tree | dc5fd78a8cb46cd1475b45eeaa6544fbdeb23280 /web/html/account.php | |
parent | bfb25807c49d3f35cdce91947a442455e1940392 (diff) |
Implement token system to fix CSRF vulnerabilities
Specially crafted pages can force authenticated users to unknowingly perform
actions on the AUR website despite being on an attacker's website. This
cross-site request forgery (CSRF) vulnerability applies to all POST data on
the AUR.
Implement a token system using a double submit cookie. Have a hidden form
value on every page containing POST forms. Use the newly added check_token() to
verify the token sent via POST matches the "AURSID" cookie value. Random
nature of the token limits potential for CSRF.
Signed-off-by: canyonknight <canyonknight@gmail.com>
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
Diffstat (limited to 'web/html/account.php')
-rw-r--r-- | web/html/account.php | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/web/html/account.php b/web/html/account.php index 387fd93..5a0ef50 100644 --- a/web/html/account.php +++ b/web/html/account.php @@ -88,11 +88,13 @@ if (isset($_COOKIE["AURSID"])) { } elseif ($action == "UpdateAccount") { # user is submitting their modifications to an existing account # - process_account_form($atype, "edit", "UpdateAccount", - in_request("U"), in_request("T"), in_request("S"), - in_request("E"), in_request("P"), in_request("C"), - in_request("R"), in_request("L"), in_request("I"), - in_request("ID")); + if (check_token()) { + process_account_form($atype, "edit", "UpdateAccount", + in_request("U"), in_request("T"), in_request("S"), + in_request("E"), in_request("P"), in_request("C"), + in_request("R"), in_request("L"), in_request("I"), + in_request("ID")); + } } else { |