diff options
author | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2017-01-15 20:25:35 -0500 |
---|---|---|
committer | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2017-02-15 00:45:43 -0500 |
commit | 561eede4d126610ee5023098fc2787bd8864f144 (patch) | |
tree | e3939d096f287f7af780dc61ce2128be5080f86a | |
parent | a7581ff940b65df9e18ab9ab941a22c8d67b250d (diff) |
coredump: add note about lack of rollback on oom
-rw-r--r-- | src/coredump/coredump.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/coredump/coredump.c b/src/coredump/coredump.c index 7b11e230bf..1bb1dbbe8d 100644 --- a/src/coredump/coredump.c +++ b/src/coredump/coredump.c @@ -1049,7 +1049,9 @@ static int gather_pid_metadata( char **comm_fallback, char **comm_ret, struct iovec *iovec, size_t *n_iovec) { - /* We need 25 empty slots in iovec! */ + /* We need 25 empty slots in iovec! + * Note that if we fail on oom later on, we do not roll-back changes to the iovec + * structure. (It remains valid, with the first n_iovec fields initialized.) */ _cleanup_free_ char *exe = NULL, *comm = NULL; uid_t owner_uid; |