diff options
| author | Tom Gundersen <teg@jklm.no> | 2014-09-18 19:26:11 +0200 |
|---|---|---|
| committer | Anthony G. Basile <blueness@gentoo.org> | 2014-09-18 18:58:06 -0400 |
| commit | 90950ff5475320158979e06e1dc202ce78fb9692 (patch) | |
| tree | 444021688c3b1052b0197f271dd0944c2e31a2e3 | |
| parent | 2345245fdf951ea3ac5f4dc876df1fac63a4fa75 (diff) | |
udev: ctrl - log if setting SO_PASSCRED fails
No functional change.
Found by Coverity. Fixes CID #1237533.
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
| -rw-r--r-- | src/udev/udev-ctrl.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/src/udev/udev-ctrl.c b/src/udev/udev-ctrl.c index 76fb2cef17..6f465166fb 100644 --- a/src/udev/udev-ctrl.c +++ b/src/udev/udev-ctrl.c @@ -74,6 +74,7 @@ struct udev_ctrl_connection { struct udev_ctrl *udev_ctrl_new_from_fd(struct udev *udev, int fd) { struct udev_ctrl *uctrl; const int on = 1; + int r; uctrl = new0(struct udev_ctrl, 1); if (uctrl == NULL) @@ -92,7 +93,9 @@ struct udev_ctrl *udev_ctrl_new_from_fd(struct udev *udev, int fd) { uctrl->bound = true; uctrl->sock = fd; } - setsockopt(uctrl->sock, SOL_SOCKET, SO_PASSCRED, &on, sizeof(on)); + r = setsockopt(uctrl->sock, SOL_SOCKET, SO_PASSCRED, &on, sizeof(on)); + if (r < 0) + log_warning("could not set SO_PASSCRED: %m"); uctrl->saddr.sun_family = AF_LOCAL; strscpy(uctrl->saddr.sun_path, sizeof(uctrl->saddr.sun_path), "/run/udev/control"); @@ -221,7 +224,10 @@ struct udev_ctrl_connection *udev_ctrl_get_connection(struct udev_ctrl *uctrl) { } /* enable receiving of the sender credentials in the messages */ - setsockopt(conn->sock, SOL_SOCKET, SO_PASSCRED, &on, sizeof(on)); + r = setsockopt(conn->sock, SOL_SOCKET, SO_PASSCRED, &on, sizeof(on)); + if (r < 0) + log_warning("colud not set SO_PASSCRED: %m"); + udev_ctrl_ref(uctrl); return conn; err: |