summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPhilippe De Swert <philippedeswert@gmail.com>2015-02-08 22:21:51 +0200
committerLennart Poettering <lennart@poettering.net>2015-02-10 21:11:52 +0100
commit2e1a569b77f656500317cf2ca2382e9222ceab2f (patch)
tree1c96ea6ee0fd7228e4be4e3b769a0f326884094b
parent20760dcf5df7e253c21a51886cdb02dee612730b (diff)
libsystemd-network: Avoid potential NULL dereference in test-lldp
As a malloc0 could fail, doing a strncpy without checking could cause issues. Adding an assert should be good enough and in line with other similar routines in the code. Found with Coverity Fixes: CID#1261402
-rw-r--r--src/libsystemd-network/test-lldp.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/libsystemd-network/test-lldp.c b/src/libsystemd-network/test-lldp.c
index 288aac5961..2e6bf14e81 100644
--- a/src/libsystemd-network/test-lldp.c
+++ b/src/libsystemd-network/test-lldp.c
@@ -166,6 +166,7 @@ static int lldp_parse_system_name_tlv(tlv_packet *m) {
assert_se(tlv_packet_read_string(m, &str, &length) >= 0);
p = malloc0(length + 1);
+ assert_se(p);
strncpy(p, str, length);
assert_se(streq(p, TEST_LLDP_TYPE_SYSTEM_NAME) == 1);