diff options
| author | Lennart Poettering <lennart@poettering.net> | 2015-09-29 13:38:36 +0200 |
|---|---|---|
| committer | Lennart Poettering <lennart@poettering.net> | 2015-09-29 21:55:53 +0200 |
| commit | 4057e12315ae4ce2325b68c0b65cf23ccbe4de55 (patch) | |
| tree | f2c44edace7617c6a5f80d8022643920be259570 | |
| parent | 14b316ebf81fd21adade2fa6d2f48cc421dc5d95 (diff) | |
systemctl: don't assert on the arguments array unnecessarily
In most verbs it's fine to treat the arguments array being NULL is empty
array, hence do so.
| -rw-r--r-- | src/systemctl/systemctl.c | 14 |
1 files changed, 0 insertions, 14 deletions
diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c index 6641aa7ebd..5bcea28411 100644 --- a/src/systemctl/systemctl.c +++ b/src/systemctl/systemctl.c @@ -2175,8 +2175,6 @@ static int cancel_job(char **args) { char **name; int r = 0; - assert(args); - if (strv_length(args) <= 1) return daemon_reload(args); @@ -3154,8 +3152,6 @@ static int check_unit_generic(int code, const char *good_states, char **args) { char **name; int r; - assert(args); - r = acquire_bus(BUS_MANAGER, &bus); if (r < 0) return r; @@ -3192,8 +3188,6 @@ static int kill_unit(char **args) { sd_bus *bus; int r, q; - assert(args); - polkit_agent_open_if_enabled(); r = acquire_bus(BUS_MANAGER, &bus); @@ -4764,8 +4758,6 @@ static int cat(char **args) { bool first = true; int r; - assert(args); - if (arg_transport != BUS_TRANSPORT_LOCAL) { log_error("Cannot remotely cat units."); return -EINVAL; @@ -4941,8 +4933,6 @@ static int delete_snapshot(char **args) { char **name; int r; - assert(args); - polkit_agent_open_if_enabled(); r = acquire_bus(BUS_MANAGER, &bus); @@ -5228,8 +5218,6 @@ static int import_environment(char **args) { sd_bus *bus; int r; - assert(args); - polkit_agent_open_if_enabled(); r = acquire_bus(BUS_MANAGER, &bus); @@ -6198,8 +6186,6 @@ static int edit(char **args) { sd_bus *bus; int r; - assert(args); - if (!on_tty()) { log_error("Cannot edit units if not on a tty."); return -EINVAL; |