summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFilipe Brandenburger <filbranden@google.com>2015-09-22 09:41:32 -0700
committerFilipe Brandenburger <filbranden@google.com>2015-09-22 09:54:33 -0700
commit6a937f0645ab335ef13a79951c3e94d6d8becea9 (patch)
treeac17e08ed69cbe201cae74a0917ae9c6180e0e4e
parent68321c9a97e6777041e4bf547cfe85a5d9c5fbb0 (diff)
build-sys: properly quote m4 macro arguments in CC_CHECK_FLAGS_APPEND
The variables should be quoted inside [...] to avoid double macro expansion. This is currently not an issue, since the values (-W...) are not really macros, but we might as well just fix that issue now. Tested by re-running autogen.sh and comparing the value of OUR_CFLAGS in the generated Makefile. Ran a full build from a clean tree to confirm no other issues were introduced.
-rw-r--r--m4/attributes.m44
1 files changed, 2 insertions, 2 deletions
diff --git a/m4/attributes.m4 b/m4/attributes.m4
index 97f094b07a..4b0fcdce3d 100644
--- a/m4/attributes.m4
+++ b/m4/attributes.m4
@@ -54,8 +54,8 @@ AC_DEFUN([CC_CHECK_FLAG_APPEND], [
dnl CC_CHECK_FLAGS_APPEND([WHERE-TO-APPEND], [ENV-VAR], [FLAG1 FLAG2])
AC_DEFUN([CC_CHECK_FLAGS_APPEND], [
- for flag in $3; do
- CC_CHECK_FLAG_APPEND($1, $2, $flag)
+ for flag in [$3]; do
+ CC_CHECK_FLAG_APPEND([$1], [$2], $flag)
done
])