summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Gundersen <teg@jklm.no>2015-04-24 17:50:49 +0200
committerTom Gundersen <teg@jklm.no>2015-04-24 19:13:48 +0200
commit70a93737ecd613d9b5855cb5d7c80829b966ec6a (patch)
tree384c00701721031dbaee56a146dc83fa9242c849
parentd71618654a7cf5addfd6d8907ee73afbf8c6dcee (diff)
udevd: improve logging in SIGCHLD handling
Remove some redundant logging, and reduce the log-level in most cases. The only case that is really critical is if a worker failed while hanlding an event, so keep that at error level.
-rw-r--r--src/udev/udevd.c18
1 files changed, 9 insertions, 9 deletions
diff --git a/src/udev/udevd.c b/src/udev/udevd.c
index 2d0ac6d61d..60e1ee6f9e 100644
--- a/src/udev/udevd.c
+++ b/src/udev/udevd.c
@@ -869,21 +869,21 @@ static void handle_signal(struct udev *udev, int signo) {
if (worker->pid != pid)
continue;
- log_debug("worker ["PID_FMT"] exit", pid);
if (WIFEXITED(status)) {
- if (WEXITSTATUS(status) != 0)
- log_error("worker ["PID_FMT"] exit with return code %i",
- pid, WEXITSTATUS(status));
+ if (WEXITSTATUS(status) == 0)
+ log_debug("worker ["PID_FMT"] exited", pid);
+ else
+ log_warning("worker ["PID_FMT"] exited with return code %i", pid, WEXITSTATUS(status));
} else if (WIFSIGNALED(status)) {
- log_error("worker ["PID_FMT"] terminated by signal %i (%s)",
- pid, WTERMSIG(status), strsignal(WTERMSIG(status)));
+ log_warning("worker ["PID_FMT"] terminated by signal %i (%s)",
+ pid, WTERMSIG(status), strsignal(WTERMSIG(status)));
} else if (WIFSTOPPED(status)) {
- log_error("worker ["PID_FMT"] stopped", pid);
+ log_info("worker ["PID_FMT"] stopped", pid);
} else if (WIFCONTINUED(status)) {
- log_error("worker ["PID_FMT"] continued", pid);
+ log_info("worker ["PID_FMT"] continued", pid);
} else {
- log_error("worker ["PID_FMT"] exit with status 0x%04x", pid, status);
+ log_warning("worker ["PID_FMT"] exit with status 0x%04x", pid, status);
}
if (!WIFEXITED(status) || WEXITSTATUS(status) != 0) {