summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLennart Poettering <lennart@poettering.net>2015-11-09 23:47:16 +0100
committerLennart Poettering <lennart@poettering.net>2015-11-10 17:31:30 +0100
commitfa195fa775e548a15c0cc21d4c8611fd0286245a (patch)
tree82c0db7fd01c01ec56014d2465d1b1abbe545bf5
parent9905e698b419d4157963f105fa6a02e2d4f89c61 (diff)
CODING_STYLE: elaborate on usage of C99 fixed size integer types
-rw-r--r--CODING_STYLE14
1 files changed, 9 insertions, 5 deletions
diff --git a/CODING_STYLE b/CODING_STYLE
index 8b945cd3c1..0064303203 100644
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -145,11 +145,15 @@
- Think about the types you use. If a value cannot sensibly be
negative, do not use "int", but use "unsigned".
-- Do not use types like "short". They *never* make sense. Use ints,
- longs, long longs, all in unsigned+signed fashion, and the fixed
- size types uint32_t and so on, as well as size_t, but nothing
- else. Do not use kernel types like u32 and so on, leave that to the
- kernel.
+- Use "char" only for actual characters. Use "uint8_t" or "int8_t"
+ when you actually mean a byte-sized signed or unsigned
+ integers. When referring to a generic byte, we generally prefer the
+ unsigned variant "uint8_t". Do not use types based on "short". They
+ *never* make sense. Use ints, longs, long longs, all in
+ unsigned+signed fashion, and the fixed size types
+ uint8_t/uint16_t/uint32_t/uint64_t/int8_t/int16_t/int32_t and so on,
+ as well as size_t, but nothing else. Do not use kernel types like
+ u32 and so on, leave that to the kernel.
- Public API calls (i.e. functions exported by our shared libraries)
must be marked "_public_" and need to be prefixed with "sd_". No