summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLennart Poettering <lennart@poettering.net>2014-12-10 01:47:59 +0100
committerLennart Poettering <lennart@poettering.net>2014-12-10 01:48:39 +0100
commitb7307642391c8ebb9724c99e6b33239e2c0ff944 (patch)
tree952fc684cfe07e7550ec7fb21df5611c303689d9
parentf7c1ad4fd4190bee32db0aa26c8e9fe7e19d8816 (diff)
mount: clarify that we really need to replace the utab inotify code with the native API for this in libmount, as soon as that's stable
-rw-r--r--TODO4
-rw-r--r--src/core/mount.c4
2 files changed, 6 insertions, 2 deletions
diff --git a/TODO b/TODO
index a09451d777..23fb68c67d 100644
--- a/TODO
+++ b/TODO
@@ -1,7 +1,5 @@
Preparations for 218:
-* port libmount hookup to use API's own inotify interface
-
* cgroup delegation issues
* should networkd's [BridgePort] section really be called like that?
@@ -43,6 +41,8 @@ External:
Features:
+* port libmount hookup to use API's own inotify interface, as soon as that is table in libmount
+
* bash completion for busctl, to make it truly useful
* journald: broken file systems are real (btrfs), we need to handle
diff --git a/src/core/mount.c b/src/core/mount.c
index 66de85b578..6b415b44e9 100644
--- a/src/core/mount.c
+++ b/src/core/mount.c
@@ -1665,6 +1665,10 @@ static int mount_dispatch_io(sd_event_source *source, int fd, uint32_t revents,
if (fd == m->utab_inotify_fd) {
bool rescan = false;
+ /* FIXME: We *really* need to replace this with
+ * libmount's own API for this, we should not hardcode
+ * internal behaviour of libmount here. */
+
for (;;) {
uint8_t buffer[INOTIFY_EVENT_MAX] _alignas_(struct inotify_event);
struct inotify_event *e;