diff options
| author | Lennart Poettering <lennart@poettering.net> | 2016-01-26 13:48:57 +0100 |
|---|---|---|
| committer | Lennart Poettering <lennart@poettering.net> | 2016-01-26 14:43:24 +0100 |
| commit | 4850d39ab72e7cb00a6e9c9aa4745c997674efa6 (patch) | |
| tree | d2fb7c6736289a78c3b7170ccdb659360745f3f5 | |
| parent | d6f4302b66fb8847dd79cdf7ea35b9eeccac8aff (diff) | |
journald: add a couple of static asserts checking logging constants
Whenever we include a log level or facility in a journal string field, make sure the compiler checks for us that that's
actually the right thing to do.
| -rw-r--r-- | src/journal/coredump.c | 2 | ||||
| -rw-r--r-- | src/journal/journal-send.c | 1 | ||||
| -rw-r--r-- | src/journal/journald-server.c | 2 |
3 files changed, 5 insertions, 0 deletions
diff --git a/src/journal/coredump.c b/src/journal/coredump.c index 7df59fe29b..8298b02439 100644 --- a/src/journal/coredump.c +++ b/src/journal/coredump.c @@ -794,6 +794,8 @@ int main(int argc, char* argv[]) { IOVEC_SET_STRING(iovec[j++], core_timestamp); IOVEC_SET_STRING(iovec[j++], "MESSAGE_ID=fc2e22bc6ee647b6b90729ab34a250b1"); + + assert_cc(2 == LOG_CRIT); IOVEC_SET_STRING(iovec[j++], "PRIORITY=2"); /* Vacuum before we write anything again */ diff --git a/src/journal/journal-send.c b/src/journal/journal-send.c index 44fa11a00e..def4caab92 100644 --- a/src/journal/journal-send.c +++ b/src/journal/journal-send.c @@ -372,6 +372,7 @@ static int fill_iovec_perror_and_send(const char *message, int skip, struct iove xsprintf(error, "ERRNO=%i", _saved_errno_); + assert_cc(3 == LOG_ERR); IOVEC_SET_STRING(iov[skip+0], "PRIORITY=3"); IOVEC_SET_STRING(iov[skip+1], buffer); IOVEC_SET_STRING(iov[skip+2], error); diff --git a/src/journal/journald-server.c b/src/journal/journald-server.c index 8c1b064e86..fd802b4461 100644 --- a/src/journal/journald-server.c +++ b/src/journal/journald-server.c @@ -866,10 +866,12 @@ void server_driver_message(Server *s, sd_id128_t message_id, const char *format, assert(s); assert(format); + assert_cc(3 == LOG_FAC(LOG_DAEMON)); IOVEC_SET_STRING(iovec[n++], "SYSLOG_FACILITY=3"); IOVEC_SET_STRING(iovec[n++], "SYSLOG_IDENTIFIER=systemd-journald"); IOVEC_SET_STRING(iovec[n++], "_TRANSPORT=driver"); + assert_cc(6 == LOG_INFO); IOVEC_SET_STRING(iovec[n++], "PRIORITY=6"); if (!sd_id128_equal(message_id, SD_ID128_NULL)) { |