summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlan Jenkins <alan-jenkins@tuffmail.co.uk>2008-09-01 16:36:43 +0200
committerKay Sievers <kay.sievers@vrfy.org>2008-09-01 16:36:43 +0200
commitbc1e4a138b6162885e167e55605a03fa82b2cb9b (patch)
tree09818e8ba92c417e173a16b999fa6f9495304351
parente08109cbc82bc37fc0a1deb202697790afdc5474 (diff)
fix uninitialized name_list error::ignore_error
Running udevd under valgrind (and then udevtrigger): ==17705== Conditional jump or move depends on uninitialised value(s) ==17705== at 0x407BBB: udev_rules_run (udev_rules.c:522) ==17705== by 0x4109F0: udev_event_process (udevd.c:145) ==17705== by 0x410E2C: udev_event_run (udevd.c:251) ==17705== by 0x411A8D: msg_queue_manager (udevd.c:581) ==17705== by 0x41386B: main (udevd.c:1284) Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
-rw-r--r--udev/udev_utils.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/udev/udev_utils.c b/udev/udev_utils.c
index 9b22de783f..f63a9fa1d0 100644
--- a/udev/udev_utils.c
+++ b/udev/udev_utils.c
@@ -77,7 +77,7 @@ struct name_entry *name_list_add(struct list_head *name_list, const char *name,
name_new = malloc(sizeof(struct name_entry));
if (name_new == NULL)
return NULL;
-
+ memset(name_new, 0x00, sizeof(struct name_entry));
strlcpy(name_new->name, name, sizeof(name_new->name));
dbg("adding '%s'\n", name_new->name);
list_add_tail(&name_new->node, &name_loop->node);
@@ -102,7 +102,7 @@ struct name_entry *name_list_key_add(struct list_head *name_list, const char *ke
name_new = malloc(sizeof(struct name_entry));
if (name_new == NULL)
return NULL;
-
+ memset(name_new, 0x00, sizeof(struct name_entry));
snprintf(name_new->name, sizeof(name_new->name), "%s=%s", key, value);
name_new->name[sizeof(name_new->name)-1] = '\0';
dbg("adding '%s'\n", name_new->name);