summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLennart Poettering <lennart@poettering.net>2015-01-27 23:13:28 +0100
committerLennart Poettering <lennart@poettering.net>2015-01-27 23:13:28 +0100
commit9993ef2e9817b35b1d467707bef12b2a140b62dc (patch)
tree63f5512bd82a3d585ed85f2b036db251f4b4e135
parent4e4885553447f6f4c014bfa3e5b5837a76a0e612 (diff)
sysv-generator: use is_symlink() utility call where appropriate
-rw-r--r--src/sysv-generator/sysv-generator.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/src/sysv-generator/sysv-generator.c b/src/sysv-generator/sysv-generator.c
index 1e4d54888c..984beab70a 100644
--- a/src/sysv-generator/sysv-generator.c
+++ b/src/sysv-generator/sysv-generator.c
@@ -147,7 +147,6 @@ static int generate_unit_file(SysvStub *s) {
_cleanup_free_ char *wants = NULL;
_cleanup_free_ char *conflicts = NULL;
int r;
- struct stat st;
before = strv_join(s->before, " ");
if (!before)
@@ -172,9 +171,9 @@ static int generate_unit_file(SysvStub *s) {
/* We might already have a symlink with the same name from a Provides:,
* or from backup files like /etc/init.d/foo.bak. Real scripts always win,
* so remove an existing link */
- if (lstat(unit, &st) == 0 && S_ISLNK(st.st_mode)) {
+ if (is_symlink(unit)) {
log_warning("Overwriting existing symlink %s with real service", unit);
- unlink(unit);
+ (void) unlink(unit);
}
f = fopen(unit, "wxe");