diff options
| author | kay.sievers@vrfy.org <kay.sievers@vrfy.org> | 2004-03-11 01:39:53 -0800 |
|---|---|---|
| committer | Greg KH <gregkh@suse.de> | 2005-04-26 21:35:09 -0700 |
| commit | 0a5417a0ebe92f96fb103399c9aacdf39c719271 (patch) | |
| tree | 2d87a638663e9d55e179ef9be0cc9f650877f659 | |
| parent | 558f80ba649fb5b8c2ac2a51e464f1aa07aa791d (diff) | |
[PATCH] "symlink only" test
Here is a test for the "symlink only" rule.
Any reason to do the apply_format() inside the loop?
I've changed it.
| -rw-r--r-- | namedev.c | 15 | ||||
| -rw-r--r-- | test/udev-test.pl | 11 |
2 files changed, 16 insertions, 10 deletions
@@ -815,16 +815,11 @@ int namedev_name_device(struct sysfs_class_device *class_dev, struct udevice *ud } if (dev->symlink[0] != '\0') { - char temp[NAME_MAX]; - info("configured rule in '%s' at line %i applied, added symlink '%s'", dev->config_file, dev->config_line, dev->symlink); - /* do not clobber dev */ - strfieldcpy(temp, dev->symlink); - apply_format(udev, temp, sizeof(temp), - class_dev, sysfs_device); - strfieldcat(udev->symlink, temp); - strfieldcat(udev->symlink, " "); + if (udev->symlink[0] != '\0') + strfieldcat(udev->symlink, " "); + strfieldcat(udev->symlink, dev->symlink); } if (dev->name[0] != '\0') { @@ -841,8 +836,8 @@ int namedev_name_device(struct sysfs_class_device *class_dev, struct udevice *ud goto done; found: - apply_format(udev, udev->name, sizeof(udev->name), - class_dev, sysfs_device); + apply_format(udev, udev->name, sizeof(udev->name), class_dev, sysfs_device); + apply_format(udev, udev->symlink, sizeof(udev->symlink), class_dev, sysfs_device); udev->partitions = dev->partitions; done: diff --git a/test/udev-test.pl b/test/udev-test.pl index 7db92691d3..c12a21ee3d 100644 --- a/test/udev-test.pl +++ b/test/udev-test.pl @@ -513,6 +513,17 @@ BUS="scsi", SYSFS{whitespace_test}="WHITE SPACE ", NAME="wrong-to-ignore" BUS="scsi", SYSFS{whitespace_test}="WHITE SPACE ", NAME="matched-with-space" EOF }, + { + desc => "SYMLINK only rule", + subsys => "block", + devpath => "block/sda", + expected => "symlink-only2", + conf => <<EOF +BUS="scsi", KERNEL="sda", SYMLINK="symlink-only1" +BUS="scsi", KERNEL="sda", SYMLINK="symlink-only2" +BUS="scsi", KERNEL="sda", NAME="link", SYMLINK="symlink0" +EOF + }, ); # set env |