diff options
| author | Michal Sekletar <msekleta@redhat.com> | 2014-06-18 18:14:51 +0200 |
|---|---|---|
| committer | Michal Sekletar <msekleta@redhat.com> | 2014-06-18 18:14:51 +0200 |
| commit | 03966da2ca04ca96dd0a1852d7fa423aaf18eba6 (patch) | |
| tree | d2ab026718d3045a99e65983b6ad3237184bd3c8 | |
| parent | 7cfa80f07e94c3e48703d145ef03a73dd6e7b983 (diff) | |
dhcp-network: remove TODO
There is no need to explicitly check version of L3 protocol in the
ethernet header because we bind socket with .sll_protocol set to
ETH_P_IP, thus we only receive IPv4 packets on the socket.
| -rw-r--r-- | src/libsystemd-network/dhcp-network.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/libsystemd-network/dhcp-network.c b/src/libsystemd-network/dhcp-network.c index 266bf13178..d7ba0efa12 100644 --- a/src/libsystemd-network/dhcp-network.c +++ b/src/libsystemd-network/dhcp-network.c @@ -38,7 +38,6 @@ int dhcp_network_bind_raw_socket(int index, union sockaddr_union *link, BPF_STMT(BPF_LD + BPF_W + BPF_LEN, 0), /* A <- packet length */ BPF_JUMP(BPF_JMP + BPF_JGE + BPF_K, sizeof(DHCPPacket), 1, 0), /* packet >= DHCPPacket ? */ BPF_STMT(BPF_RET + BPF_K, 0), /* ignore */ - /* TODO: match ip.version */ BPF_STMT(BPF_LD + BPF_B + BPF_ABS, offsetof(DHCPPacket, ip.protocol)), /* A <- IP protocol */ BPF_JUMP(BPF_JMP + BPF_JEQ + BPF_K, IPPROTO_UDP, 1, 0), /* IP protocol == UDP ? */ BPF_STMT(BPF_RET + BPF_K, 0), /* ignore */ |