diff options
| author | Michal Sekletar <msekleta@redhat.com> | 2013-11-06 11:18:01 +0100 |
|---|---|---|
| committer | Lennart Poettering <lennart@poettering.net> | 2013-11-07 22:25:42 +0100 |
| commit | 0a2c2294265d1d4552af3e7a92df0d4560deb818 (patch) | |
| tree | b596a78b06f54bc96591a246826a040eedae0b8a | |
| parent | 47c649b5de480b832bb11e0d52ba58d962d61fb2 (diff) | |
net-util: call ioctl() only if necessary
In case when update of current values is not necessary we still might end up
calling ioctl(), because need_update variable is not explicitly initialized.
| -rw-r--r-- | src/udev/net/ethtool-util.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/udev/net/ethtool-util.c b/src/udev/net/ethtool-util.c index 68ddd25a90..c644f91d02 100644 --- a/src/udev/net/ethtool-util.c +++ b/src/udev/net/ethtool-util.c @@ -67,7 +67,7 @@ int ethtool_set_speed(int fd, const char *ifname, unsigned int speed, Duplex dup { struct ifreq ifr; struct ethtool_cmd ecmd; - bool need_update; + bool need_update = false; int r; if (speed == 0 && duplex == _DUP_INVALID) @@ -120,7 +120,7 @@ int ethtool_set_speed(int fd, const char *ifname, unsigned int speed, Duplex dup int ethtool_set_wol(int fd, const char *ifname, WakeOnLan wol) { struct ifreq ifr; struct ethtool_wolinfo ecmd; - bool need_update; + bool need_update = false; int r; if (wol == _WOL_INVALID) |