diff options
author | Lennart Poettering <lennart@poettering.net> | 2015-10-06 15:52:03 +0200 |
---|---|---|
committer | Lennart Poettering <lennart@poettering.net> | 2015-10-06 15:52:03 +0200 |
commit | c7ddad5148de6e41445f62a80fb6846dce1a6856 (patch) | |
tree | 844f5fa6f2b910a404804fdbe1abeaee86be05b9 | |
parent | 13af9152bc3c018849e1834f5ff93f2a8ed03afb (diff) |
update CODING_STYLE
-rw-r--r-- | CODING_STYLE | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/CODING_STYLE b/CODING_STYLE index cf86de5f62..7fd4af8b87 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -332,9 +332,13 @@ - Avoid leaving long-running child processes around, i.e. fork()s that are not followed quickly by an execv() in the child. Resource management is unclear in this case, and memory CoW will result in - penalties in the parent much much later on. + unexpected penalties in the parent much much later on. - Don't block execution for arbitrary amounts of time using usleep() or a similar call, unless you really know what you do. Just "giving something some time", or so is a lazy excuse. Always wait for the proper event, instead of doing time-based poll loops. + +- To determine the length of a constant string "foo", don't bother + with sizeof("foo")-1, please use strlen("foo") directly. gcc knows + strlen() anyway and turns it into a constant expression if possible. |