summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Gundersen <teg@jklm.no>2014-09-25 18:16:04 +0200
committerTom Gundersen <teg@jklm.no>2014-09-25 18:16:04 +0200
commit3d1b90bd7fb562fdb3d15e0d7750ae0c36bc15b6 (patch)
treeb64f30e57ce140566c90480d406e91abe5a5470b
parentd6bc8348d5be8576a475ac8ced2b0146e60fb71f (diff)
delta: warn if diff failed
Found by Coverity. Fixes CID #1237541.
-rw-r--r--src/delta/delta.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/src/delta/delta.c b/src/delta/delta.c
index 91f8592b40..2fdbeeae81 100644
--- a/src/delta/delta.c
+++ b/src/delta/delta.c
@@ -159,7 +159,7 @@ static int notify_override_unchanged(const char *f) {
static int found_override(const char *top, const char *bottom) {
_cleanup_free_ char *dest = NULL;
- int k;
+ int k, r;
pid_t pid;
assert(top);
@@ -194,7 +194,9 @@ static int found_override(const char *top, const char *bottom) {
_exit(1);
}
- wait_for_terminate(pid, NULL);
+ r = wait_for_terminate(pid, NULL);
+ if (r < 0)
+ log_warning("Failed to wait for diff: %s", strerror(-r));
putchar('\n');