diff options
| author | Tom Gundersen <teg@jklm.no> | 2015-08-25 14:12:19 +0200 |
|---|---|---|
| committer | Tom Gundersen <teg@jklm.no> | 2015-09-02 14:24:17 +0200 |
| commit | 54683f0f9b97a8f88aaf4fbb45b4d729057b101c (patch) | |
| tree | 9b8bf63b5c1e153fb0099c691511f655a1ee361b | |
| parent | fc94c3260549c12892461be031c4b9dc122ca1ef (diff) | |
udev: net_id - support predictable ifnames on virtio buses
Virtio buses are undeterministically enumerated, so we cannot use them as a basis
for deterministic naming (see bf81e792f3c0). However, we are guaranteed that there
is only ever one virtio bus for every parent device, so we can simply skip over
the virtio buses when naming the devices.
| -rw-r--r-- | src/udev/udev-builtin-net_id.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/src/udev/udev-builtin-net_id.c b/src/udev/udev-builtin-net_id.c index 6e7e1271fb..589f1f7822 100644 --- a/src/udev/udev-builtin-net_id.c +++ b/src/udev/udev-builtin-net_id.c @@ -280,8 +280,16 @@ static int names_pci(struct udev_device *dev, struct netnames *names) { assert(names); parent = udev_device_get_parent(dev); + + /* there can only ever be one virtio bus per parent device, so we can + safely ignore any virtio buses. see + <http://lists.linuxfoundation.org/pipermail/virtualization/2015-August/030331.html> */ + while (parent && streq_ptr("virtio", udev_device_get_subsystem(parent))) + parent = udev_device_get_parent(parent); + if (!parent) return -ENOENT; + /* check if our direct parent is a PCI device with no other bus in-between */ if (streq_ptr("pci", udev_device_get_subsystem(parent))) { names->type = NET_PCI; |