summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichal Schmidt <mschmidt@redhat.com>2015-10-13 16:52:53 +0200
committerMichal Schmidt <mschmidt@redhat.com>2015-10-14 14:43:38 +0200
commit7f7bfcf3cfc6f0d9fabffb63a44b607a7a040d57 (patch)
tree4861a8bdac0d32edc67b570e355f907bf1a8b19f
parentc7e2496a2194557c8c52317209d1020dee845117 (diff)
build: fix overlinking to libdw
We have two AC_CHECK_LIB checks for libdw. The first one has an empty action-if-found, so it defaults to adding "-ldw" to LIBS. LIBS are applied to everything we build. But only systemd-coredump needs libdw. It already links to ELFUTILS_LIBS correctly in Makefile.am. Drop the first AC_CHECK_LIB check. The second check is sufficient. Q: Don't we already use "-Wl,--as-needed" to eliminate overlinking? A: We do, but it is effective only for executables, not for shared libraries. This is due to a libtool bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=347650
-rw-r--r--configure.ac8
1 files changed, 0 insertions, 8 deletions
diff --git a/configure.ac b/configure.ac
index c658c7fca3..8f273c6990 100644
--- a/configure.ac
+++ b/configure.ac
@@ -790,14 +790,6 @@ if test "x${have_elfutils}" != xno ; then
AC_CHECK_LIB(
[dw],
- [dwfl_begin],
- [],
- [if test "x$have_elfutils" = xyes ; then
- AC_MSG_ERROR([*** ELFUTILS libs not found.])
- fi])
-
- AC_CHECK_LIB(
- [dw],
[dwfl_core_file_attach],
[have_elfutils=yes],
[if test "x$have_elfutils" = xyes ; then