diff options
| author | David Herrmann <dh.herrmann@gmail.com> | 2015-07-16 14:35:15 +0200 |
|---|---|---|
| committer | David Herrmann <dh.herrmann@gmail.com> | 2015-07-16 15:01:52 +0200 |
| commit | 1af5f746d569f013595bb16ca113741ee306f04a (patch) | |
| tree | 1d2b7f24f9cd9c8819d6dfbf7959d89049206be2 | |
| parent | 4f1d774135ae8c6fedb3a9dee45efe1fb42ac389 (diff) | |
sd-bus: destination-matches cannot match NameOwnerChanged
Make sure we don't install NameOwnerChanged matches if the caller passed
a destination='' match (except if it is the broadcast address). Per spec,
all NameOwnerChanged signals are broadcasts.
Only the NameLost/NameAcquired signals are unicasts, but those are never
received through sd-bus. Instead, the bus-proxy synthesizes them and it
already installs proper matches for them.
| -rw-r--r-- | src/libsystemd/sd-bus/bus-control.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/libsystemd/sd-bus/bus-control.c b/src/libsystemd/sd-bus/bus-control.c index a38c5c50fc..526e1aa89f 100644 --- a/src/libsystemd/sd-bus/bus-control.c +++ b/src/libsystemd/sd-bus/bus-control.c @@ -1345,6 +1345,10 @@ int bus_add_match_internal_kernel( else if (r > 0) sz += ALIGN8(offsetof(struct kdbus_item, id) + sizeof(uint64_t)); + /* if not a broadcast, it cannot be a name-change */ + if (r <= 0 || dst_id != KDBUS_DST_ID_BROADCAST) + matches_name_change = false; + break; } |