diff options
| author | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2016-05-16 15:44:35 -0400 |
|---|---|---|
| committer | Lennart Poettering <lennart@poettering.net> | 2016-05-16 21:44:35 +0200 |
| commit | a87c45a84b080906c1ccaa154821e70184c39ec1 (patch) | |
| tree | 051e81c25e566c1ecee91ef8ae9cadc55de45474 | |
| parent | cd042078df2151d7824abf91107a0d4a8716e54f (diff) | |
CONTRIBUTING: recommend force-push (#3273)
| -rw-r--r-- | .github/CONTRIBUTING.md | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 18081cbb48..60f0fb9bef 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -24,10 +24,7 @@ right-away for being misfiled. code. This is a requirement for all code we merge. * Make sure to run "make check" locally, before posting your PR. We use a CI system, meaning we don't even look at your PR, if the build and tests don't pass. -* If you need to update the code in an existing PR, please consider opening a new PR (mentioning in it which old PR it - replaces) and closing the old PR. This is much preferable over force-pushing a new patch set into the PR's branch, as - commit comments aren't lost that way. That said, we don't follow this rule ourselves quite often, hence this is - really just a say as we say, not say as we do... +* If you need to update the code in an existing PR, force-push into the same branch, overriding old commits with new versions. ## Final Words |