summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Gundersen <teg@jklm.no>2014-05-24 00:46:30 +0200
committerTom Gundersen <teg@jklm.no>2014-05-24 00:46:30 +0200
commit68baa8faf30f4e097bcf32d5b2d4880f85a0bdc7 (patch)
tree6348d3b6b22c72c22965e0c142910958d33ab8a2
parent640ace4a8de907994a1b95f6d368c3e6a8fcf60f (diff)
sd-network: avoid false positive compiler warning caused by LTO
Djalal Harouni <tixxdz@opendz.org>: There is also this one genrated by LTO, IMO it's a false positive since we do *check* for "lease" but the code is not consistent since in that code path, "lease" is initialized to NULL in other places, except for this one: src/resolve/resolved-manager.c: In function 'manager_update_resolv_conf': src/libsystemd-network/sd-dhcp-lease.c:67:18: warning: 'lease' may be used uninitialized in this function [-Wmaybe-uninitialized] if (lease->dns_size) { ^ src/network/sd-network.c:146:24: note: 'lease' was declared here sd_dhcp_lease *lease; ^
-rw-r--r--src/network/sd-network.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/network/sd-network.c b/src/network/sd-network.c
index e7cda0d510..ba13a30aec 100644
--- a/src/network/sd-network.c
+++ b/src/network/sd-network.c
@@ -143,7 +143,7 @@ _public_ int sd_network_get_link_operational_state(unsigned index, char **state)
_public_ int sd_network_get_dhcp_lease(unsigned index, sd_dhcp_lease **ret) {
_cleanup_free_ char *p = NULL, *s = NULL;
- sd_dhcp_lease *lease;
+ sd_dhcp_lease *lease = NULL;
int r;
assert_return(index, -EINVAL);