summaryrefslogtreecommitdiff
path: root/CODING_STYLE
diff options
context:
space:
mode:
authorLennart Poettering <lennart@poettering.net>2014-10-27 18:09:07 +0100
committerLennart Poettering <lennart@poettering.net>2014-10-27 18:09:26 +0100
commit7f8bf08f9036de419ad14c55b61eda74c6659d3a (patch)
tree35beb62a17ae225d211434111958607c3393e392 /CODING_STYLE
parentdbfd41e2df44113d1d2d07fb751db11b443f186b (diff)
CODING_STYLE: don't clobber arguments on failure
Diffstat (limited to 'CODING_STYLE')
-rw-r--r--CODING_STYLE6
1 files changed, 5 insertions, 1 deletions
diff --git a/CODING_STYLE b/CODING_STYLE
index 598d241b2b..4439ee6099 100644
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -182,7 +182,11 @@
is_main_thread() to detect whether the calling thread is the main
thread.
-- Option parsing:
+- Command line option parsing:
- Do not print full help() on error, be specific about the error.
- Do not print messages to stdout on error.
- Do not POSIX_ME_HARDER unless necessary, i.e. avoid "+" in option string.
+
+- Do not write functions that clobber call-by-reference variables on
+ failure. Use temporary variables for these cases and change the
+ passed in variables only on success.