diff options
author | Ian Stakenvicius <axs@gentoo.org> | 2013-07-11 14:04:02 -0400 |
---|---|---|
committer | Ian Stakenvicius <axs@gentoo.org> | 2013-08-02 12:03:36 -0400 |
commit | d9488d78ebc2dde8ac4065381780e4d974056e92 (patch) | |
tree | 18fadf819a86da759cc9ad49807802dfa20d530a /CONTRIBUTING | |
parent | e2f82dc60f6fc7988c258ebb0aa27e112ad3ce04 (diff) |
rule-generator: proactively rename ifaces to avoid conflicts
When a new network iface device is added, scan through the list of rules to see if its
kernel-assigned name is used as a target for another device. If so, and said target device
is not this device, rename it to a temporary interface name. Then rename the device in
accordance with any rename rules that may apply to this device, if applicable.
The temporary name assigned is the basename of the interface with a numeric compoment which is
close to the inverse of the numeric id (127 - id#). This should provide a more user-friendly
output than the old 'rename#' behaviour, when there is no final target name for the iface.
This proactive temporary rename will prevent cases where old-style rule-generator rules are used
and a target NAME= is set for one iface, assigning it to the iface name used by a second iface,
and that second iface has no rename rule to apply. The original rename code would be blocked
due to the conflict and time out when attempting to rename, leaving the interface assigned to the
temporary 'rename[id#]' name and/or failing to rename other ifaces in accordance with the existing
rules. This is a corner case that only occurrs when 75-persistent-net-generator.rules or the
write_net_rules script it 'IMPORTS' fails to generate a new rule and rename the interface and
there is no other interface-renaming rules that apply.
There may also be performance benefits to renaming ifaces early, but no benchmarks have been
run to confirm this.
Signed-off-by: Ian Stakenvicius <axs@gentoo.org>
Diffstat (limited to 'CONTRIBUTING')
0 files changed, 0 insertions, 0 deletions