summaryrefslogtreecommitdiff
path: root/coccinelle
diff options
context:
space:
mode:
authorLennart Poettering <lennart@poettering.net>2015-09-08 19:14:10 +0200
committerLennart Poettering <lennart@poettering.net>2015-09-09 08:20:20 +0200
commit3cc2aff1abff9e34f9fec282d970204dc1eab6f1 (patch)
tree39d4b5f8f9980aeacaf64b4c3078f51a46a3b63e /coccinelle
parent7f6e12b03300ba3e473ce6b85d823fc0375b335e (diff)
tree-wide: don't do assignments within if checks
Turn this: if ((r = foo()) < 0) { ... into this: r = foo(); if (r < 0) { ...
Diffstat (limited to 'coccinelle')
-rw-r--r--coccinelle/no-if-assignments.cocci20
1 files changed, 20 insertions, 0 deletions
diff --git a/coccinelle/no-if-assignments.cocci b/coccinelle/no-if-assignments.cocci
new file mode 100644
index 0000000000..9f63e90337
--- /dev/null
+++ b/coccinelle/no-if-assignments.cocci
@@ -0,0 +1,20 @@
+@@
+expression p, q;
+identifier r;
+statement s;
+@@
+- if ((r = q) < p)
+- s
++ r = q;
++ if (r < p)
++ s
+@@
+expression p, q;
+identifier r;
+statement s;
+@@
+- if ((r = q) >= p)
+- s
++ r = q;
++ if (r >= p)
++ s