summaryrefslogtreecommitdiff
path: root/extras/hid2hci
diff options
context:
space:
mode:
authorMartin Pitt <martin.pitt@ubuntu.com>2009-06-26 08:17:23 +0200
committerMartin Pitt <martin.pitt@ubuntu.com>2009-06-26 08:17:23 +0200
commitb53c3a21b9992915f89624f60e85fe50b7aad4ad (patch)
treef528bd51fc5364a2a094d46f6c154e6acc96c71a /extras/hid2hci
parent7d063096c44630593b13eae76c03619b974e0364 (diff)
hid2hci: narrow matches to real HCI devices
The previous rules just checked bInterfaceProtocol but not the actual device and interface class. This caused the hci rules to be applied for Dell USB hubs and attached input devices like keyboards and mouses as well, breaking them completely. Tighten the match to also check device and interface class/subclass. https://launchpad.net/bugs/392144
Diffstat (limited to 'extras/hid2hci')
-rw-r--r--extras/hid2hci/70-hid2hci.rules2
1 files changed, 1 insertions, 1 deletions
diff --git a/extras/hid2hci/70-hid2hci.rules b/extras/hid2hci/70-hid2hci.rules
index 2cb2746050..caf9120f53 100644
--- a/extras/hid2hci/70-hid2hci.rules
+++ b/extras/hid2hci/70-hid2hci.rules
@@ -8,7 +8,7 @@ SUBSYSTEM!="usb", GOTO="hid2hci_end"
# is where a HID report needs to be sent to switch modes.
#
# Known supported devices: 413c:8154, 413c:8158, 413c:8162
-ATTR{bInterfaceProtocol}=="02", ATTRS{idVendor}=="413c", ATTRS{bmAttributes}=="e0", \
+ATTR{bInterfaceClass}=="03", ATTR{bInterfaceSubClass}=="01", ATTR{bInterfaceProtocol}=="02", ATTRS{bDeviceClass}=="00", ATTRS{idVendor}=="413c", ATTRS{bmAttributes}=="e0", \
RUN+="hid2hci --method dell -v $attr{idVendor} -p $attr{idProduct} --mode hci"
ENV{DEVTYPE}!="usb_device", GOTO="hid2hci_end"