summaryrefslogtreecommitdiff
path: root/extras/scsi_id
diff options
context:
space:
mode:
authorKay Sievers <kay.sievers@vrfy.org>2008-11-21 07:26:44 +0100
committerKay Sievers <kay.sievers@vrfy.org>2008-11-21 07:26:44 +0100
commitf1ab8f912e06e50e6e42c3e3ece259d7f3e81f6b (patch)
tree40c52c0d3e54e6eef3ac12b70a9731d106c5f818 /extras/scsi_id
parent7106902dce55b68a878cb209e55222a904ff10ff (diff)
volume_id: clear probing result before probing and do not probe a second time, if not needed
On Thu, Nov 20, 2008 at 14:17, Karel Zak <kzak@redhat.com> wrote: > I see the patch (volume_id_probe_filesystem()) and a few things come > to mind: > > - shouldn't be the relevant parts (label, uuid, version, ...) of > the "struct volume_id" zeroized when you found a signature and > before you call the next probing function? > > - it seems as overkill to use two for()s and probe two times for all > filesystems. What about to store the first result and re-use it? > > - .. or at least never use the second for() when the fist for() found > nothing ;-)
Diffstat (limited to 'extras/scsi_id')
0 files changed, 0 insertions, 0 deletions