diff options
author | Franck Bui <fbui@suse.com> | 2017-02-08 20:56:22 +0100 |
---|---|---|
committer | Lennart Poettering <lennart@poettering.net> | 2017-02-08 20:56:22 +0100 |
commit | 4470860388e12a5dda1d65773e411a349221a3e9 (patch) | |
tree | a6091a3faaf3181015573ca51fe1059642cf98e4 /man/sd_session_is_active.xml | |
parent | bd9bb4ca61da76aa03f54f2c2da4ae11b1bd96fa (diff) |
sd-event: "when exiting no signal event are pending" is a wrong assertion (#5271)
The code make the following assertion: when freeing a event loop object
(usually it's done after exiting from the main event loop), no signal events
are still queued and are pending.
This assertion can be found in event_unmask_signal_data() with
"assert(!d->current);" assertion.
It appears that this assertion can be wrong at least in a specific case
described below.
Consider the following example which is inspired from udev: a process defines 3
source events: 2 are created by sd_event_add_signal() and 1 is created by
sd_event_add_post().
1. the process receives the 2 signals consecutively so that signal 'A' source
event is queued and pending. Consequently the post source event is also
queued and pending. This is done by sd_event_wait().
2. The callback for signal 'A' is called by sd_event_dispatch().
3. The next call to sd_event_wait() will queue signal 'B' source event.
4. The callback for the post source event is called and calls sd_event_exit().
5. the event loop is exited.
6. freeing the event loop object will lead to the assertion failure in
event_unmask_signal_data().
This patch simply removes this assertion as it doesn't seem to be a
bug if the signal data still reference a signal source at this point.
Diffstat (limited to 'man/sd_session_is_active.xml')
0 files changed, 0 insertions, 0 deletions