summaryrefslogtreecommitdiff
path: root/src/analyze/analyze.c
diff options
context:
space:
mode:
authorŁukasz Stelmach <l.stelmach@samsung.com>2015-10-07 08:02:31 +0200
committerŁukasz Stelmach <l.stelmach@samsung.com>2015-10-07 08:02:31 +0200
commitfebda62a36bea0a817b8bc6e63d71e74f65845ba (patch)
tree635c6504eeef57407ce57ece446b799d0ee632bc /src/analyze/analyze.c
parent69b8a8ebaeaae13e82d44b386555921877bc0309 (diff)
analyze: minor fixes according to review
+ use _cleanup_host_info in acquire_host_info() + revert the first strempty() to show "Linux" string in case os_pretty_name is missing.
Diffstat (limited to 'src/analyze/analyze.c')
-rw-r--r--src/analyze/analyze.c9
1 files changed, 4 insertions, 5 deletions
diff --git a/src/analyze/analyze.c b/src/analyze/analyze.c
index c2ebdc3443..a76990360a 100644
--- a/src/analyze/analyze.c
+++ b/src/analyze/analyze.c
@@ -435,7 +435,7 @@ fail:
static int acquire_host_info(sd_bus *bus, struct host_info **hi) {
int r;
- struct host_info *host;
+ _cleanup_host_info_ struct host_info *host;
_cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL;
static const struct bus_properties_map hostname_map[] = {
@@ -471,13 +471,12 @@ static int acquire_host_info(sd_bus *bus, struct host_info **hi) {
"/org/freedesktop/systemd1",
manager_map,
host);
- if (r < 0) {
- free_host_info(host);
+ if (r < 0)
return log_error_errno(r, "Failed to get host information from systemd: %s",
bus_error_message(&error, r));
- }
*hi = host;
+ host = NULL;
return 0;
}
@@ -658,7 +657,7 @@ static int analyze_plot(sd_bus *bus) {
svg("<rect class=\"background\" width=\"100%%\" height=\"100%%\" />\n");
svg("<text x=\"20\" y=\"50\">%s</text>", pretty_times);
svg("<text x=\"20\" y=\"30\">%s %s (%s %s %s) %s %s</text>",
- strempty(host->os_pretty_name),
+ isempty(host->os_pretty_name) ? "Linux" : host->os_pretty_name,
strempty(host->hostname),
strempty(host->kernel_name),
strempty(host->kernel_release),