summaryrefslogtreecommitdiff
path: root/src/basic/io-util.c
diff options
context:
space:
mode:
authorLennart Poettering <lennart@poettering.net>2016-05-06 13:29:26 +0200
committerLennart Poettering <lennart@poettering.net>2016-05-06 13:29:26 +0200
commit60d9771c593e0702a892a4372443e63b38cdbcba (patch)
tree8c9e737e8ada747d89705e68e6b136cba0365bf1 /src/basic/io-util.c
parent01a8b4675739463b8d6abf0931099b244c6f072b (diff)
core: rework how we flush incoming traffic when a socket unit goes down
Previously, we'd simply close and reopen the socket file descriptors. This is problematic however, as we won't transition through the SOCKET_CHOWN state then, and thus the file ownership won't be correct for the sockets. Rework the flushing logic, and actually read any queued data from the sockets for flushing, and accept any queued messages and disconnect them.
Diffstat (limited to 'src/basic/io-util.c')
-rw-r--r--src/basic/io-util.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/src/basic/io-util.c b/src/basic/io-util.c
index 0037a37f2a..cc6dfa8c1b 100644
--- a/src/basic/io-util.c
+++ b/src/basic/io-util.c
@@ -33,6 +33,11 @@ int flush_fd(int fd) {
.events = POLLIN,
};
+ /* Read from the specified file descriptor, until POLLIN is not set anymore, throwing away everything
+ * read. Note that some file descriptors (notable IP sockets) will trigger POLLIN even when no data can be read
+ * (due to IP packet checksum mismatches), hence this function is only safe to be non-blocking if the fd used
+ * was set to non-blocking too. */
+
for (;;) {
char buf[LINE_MAX];
ssize_t l;