diff options
author | Filipe Brandenburger <filbranden@google.com> | 2015-09-05 16:52:51 -0700 |
---|---|---|
committer | Filipe Brandenburger <filbranden@google.com> | 2015-09-22 09:54:33 -0700 |
commit | a01a4517e16c532fbd5203fbfe2571255e2cd312 (patch) | |
tree | 8dd5d51839ebd7b5fb173a13ac65ba8f85f045ec /src/basic/missing.h | |
parent | 6a937f0645ab335ef13a79951c3e94d6d8becea9 (diff) |
build-sys: Check behavior of -Werror=shadow before deciding to use it
gcc versions 4.6 and earlier used to complain when a local variable
shadows a global function, 4.7 and above only complain if a local
variable shadows a global variable.
Fix this by checking whether gcc 4.7+ behavior is in place before
deciding to use -Werror=shadow in $(CFLAGS), by using a custom test
program source that shadows a global function with a local variable and
confirming that -Werror=shadow does not make the compile to break.
Tested:
- On gcc 4.7 and 4.8, confirmed nothing changed (other than the order of
the -Werror=shadow argument, going to the end of CFLAGS.)
- On gcc 4.6, confirmed by looking at the config.log output that the
check for -Werror=shadow failed and it was not included in CFLAGS.
- Ran `make V=1` to confirm -Werror=shadow was still in use, introduced
a bogus shadowing issue and confirmed it was caught when building with
a recent gcc.
Diffstat (limited to 'src/basic/missing.h')
0 files changed, 0 insertions, 0 deletions