diff options
| author | Lennart Poettering <lennart@poettering.net> | 2015-09-08 19:14:10 +0200 |
|---|---|---|
| committer | Lennart Poettering <lennart@poettering.net> | 2015-09-09 08:20:20 +0200 |
| commit | 3cc2aff1abff9e34f9fec282d970204dc1eab6f1 (patch) | |
| tree | 39d4b5f8f9980aeacaf64b4c3078f51a46a3b63e /src/basic | |
| parent | 7f6e12b03300ba3e473ce6b85d823fc0375b335e (diff) | |
tree-wide: don't do assignments within if checks
Turn this:
if ((r = foo()) < 0) { ...
into this:
r = foo();
if (r < 0) { ...
Diffstat (limited to 'src/basic')
| -rw-r--r-- | src/basic/fdset.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/basic/fdset.c b/src/basic/fdset.c index a4823e6659..d70fe156a2 100644 --- a/src/basic/fdset.c +++ b/src/basic/fdset.c @@ -201,9 +201,11 @@ int fdset_cloexec(FDSet *fds, bool b) { assert(fds); - SET_FOREACH(p, MAKE_SET(fds), i) - if ((r = fd_cloexec(PTR_TO_FD(p), b)) < 0) + SET_FOREACH(p, MAKE_SET(fds), i) { + r = fd_cloexec(PTR_TO_FD(p), b); + if (r < 0) return r; + } return 0; } |