summaryrefslogtreecommitdiff
path: root/src/core/dbus-snapshot.c
diff options
context:
space:
mode:
authorLennart Poettering <lennart@poettering.net>2013-11-21 19:34:37 +0100
committerLennart Poettering <lennart@poettering.net>2013-11-21 21:12:36 +0100
commitebcf1f97de4f6b1580ae55eb56b1a3939fe6b602 (patch)
treedef5185990acebac842ed8fca253531d88897a4a /src/core/dbus-snapshot.c
parent0ccad099d4c08dc5a16c87cdd6eefc05e9d4b670 (diff)
bus: rework message handlers to always take an error argument
Message handler callbacks can be simplified drastically if the dispatcher automatically replies to method calls if errors are returned. Thus: add an sd_bus_error argument to all message handlers. When we dispatch a message handler and it returns negative or a set sd_bus_error we send this as message error back to the client. This means errors returned by handlers by default are given back to clients instead of rippling all the way up to the event loop, which is desirable to make things robust. As a side-effect we can now easily turn the SELinux checks into normal function calls, since the method call dispatcher will generate the right error replies automatically now. Also, make sure we always pass the error structure to all property and method handlers as last argument to follow the usual style of passing variables for return values as last argument.
Diffstat (limited to 'src/core/dbus-snapshot.c')
-rw-r--r--src/core/dbus-snapshot.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/src/core/dbus-snapshot.c b/src/core/dbus-snapshot.c
index 1e53fefc66..a54dc8cf89 100644
--- a/src/core/dbus-snapshot.c
+++ b/src/core/dbus-snapshot.c
@@ -25,14 +25,17 @@
#include "dbus-unit.h"
#include "dbus-snapshot.h"
-int bus_snapshot_method_remove(sd_bus *bus, sd_bus_message *message, void *userdata) {
+int bus_snapshot_method_remove(sd_bus *bus, sd_bus_message *message, void *userdata, sd_bus_error *error) {
Snapshot *s = userdata;
+ int r;
assert(bus);
assert(message);
assert(s);
- SELINUX_UNIT_ACCESS_CHECK(UNIT(s), bus, message, "stop");
+ r = selinux_unit_access_check(UNIT(s), bus, message, "stop", error);
+ if (r < 0)
+ return r;
snapshot_remove(s);