diff options
| author | Ivan Shapovalov <intelfx100@gmail.com> | 2015-03-07 08:44:52 -0500 |
|---|---|---|
| committer | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2015-03-07 08:44:57 -0500 |
| commit | 6e392c9c45643d106673c6643ac8bf4e65da13c1 (patch) | |
| tree | 77cd87fdc7f0e104f2f48fb0ea282111dde94766 /src/core/socket.c | |
| parent | 6829cec4dce1b41c895425a120b70d0a3ed677ab (diff) | |
core: do not spawn jobs or touch other units during coldplugging
Because the order of coldplugging is not defined, we can reference a
not-yet-coldplugged unit and read its state while it has not yet been
set to a meaningful value.
This way, already active units may get started again.
We fix this by deferring such actions until all units have been at
least somehow coldplugged.
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=88401
Diffstat (limited to 'src/core/socket.c')
| -rw-r--r-- | src/core/socket.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/core/socket.c b/src/core/socket.c index 9606ac2b1c..f67370b4cb 100644 --- a/src/core/socket.c +++ b/src/core/socket.c @@ -1322,7 +1322,7 @@ static void socket_set_state(Socket *s, SocketState state) { unit_notify(UNIT(s), state_translation_table[old_state], state_translation_table[state], true); } -static int socket_coldplug(Unit *u) { +static int socket_coldplug(Unit *u, Hashmap *deferred_work) { Socket *s = SOCKET(u); int r; |