diff options
author | Lennart Poettering <lennart@poettering.net> | 2014-11-06 14:09:51 +0100 |
---|---|---|
committer | Lennart Poettering <lennart@poettering.net> | 2014-11-06 14:21:11 +0100 |
commit | 493657337ad8569e0998a3afa7d6fb357757364a (patch) | |
tree | 058cfe40cd4e86f43d9b02020575c2819aef1fed /src/core/unit.c | |
parent | c073a0c4a5ffbf6677dd6af02e7c7d59b2b901ab (diff) |
core: get rid of condition.c and move the remaining call into util.c
That way only one file with condition code remaining, in src/shared/,
rather than src/core/.
Next step: dropping the "-util" suffix from condition-util.[ch].
Diffstat (limited to 'src/core/unit.c')
-rw-r--r-- | src/core/unit.c | 51 |
1 files changed, 49 insertions, 2 deletions
diff --git a/src/core/unit.c b/src/core/unit.c index 66f53ddc7c..948f8e21bd 100644 --- a/src/core/unit.c +++ b/src/core/unit.c @@ -1245,11 +1245,58 @@ fail: return r; } +static bool unit_condition_test_list(Unit *u, Condition *first, const char *(*to_string)(ConditionType t)) { + Condition *c; + int triggered = -1; + + assert(u); + assert(to_string); + + /* If the condition list is empty, then it is true */ + if (!first) + return true; + + /* Otherwise, if all of the non-trigger conditions apply and + * if any of the trigger conditions apply (unless there are + * none) we return true */ + LIST_FOREACH(conditions, c, first) { + int r; + + r = condition_test(c); + if (r < 0) + log_warning_unit(u->id, + "Couldn't determine result for %s=%s%s%s for %s, assuming failed: %s", + to_string(c->type), + c->trigger ? "|" : "", + c->negate ? "!" : "", + c->parameter, + u->id, + strerror(-r)); + else + log_debug_unit(u->id, + "%s=%s%s%s %s for %s.", + to_string(c->type), + c->trigger ? "|" : "", + c->negate ? "!" : "", + c->parameter, + condition_result_to_string(c->result), + u->id); + + if (!c->trigger && r <= 0) + return false; + + if (c->trigger && triggered <= 0) + triggered = r > 0; + } + + return triggered != 0; +} + static bool unit_condition_test(Unit *u) { assert(u); dual_timestamp_get(&u->condition_timestamp); - u->condition_result = condition_test_list(u->id, u->conditions, condition_type_to_string); + u->condition_result = unit_condition_test_list(u, u->conditions, condition_type_to_string); return u->condition_result; } @@ -1258,7 +1305,7 @@ static bool unit_assert_test(Unit *u) { assert(u); dual_timestamp_get(&u->assert_timestamp); - u->assert_result = condition_test_list(u->id, u->asserts, assert_type_to_string); + u->assert_result = unit_condition_test_list(u, u->asserts, assert_type_to_string); return u->assert_result; } |