Convert the rest to sd_bus_errnomap

I tried to preserve most errno values, but in some cases they were
inconsistent (different errno values for the same error name) or just
mismatched.

3 files changed, 44 insertions, 66 deletions

diff --git a/src/core/manager.c b/src/core/manager.c
index d427d88d4e..ed7fdc71d7 100644
--- a/src/core/manager.c
+++ b/src/core/manager.c
@@ -1189,15 +1189,11 @@ int manager_add_job(Manager *m, JobType type, Unit *unit, JobMode mode, bool ove
         assert(unit);
         assert(mode < _JOB_MODE_MAX);
 
-        if (mode == JOB_ISOLATE && type != JOB_START) {
-                sd_bus_error_setf(e, SD_BUS_ERROR_INVALID_ARGS, "Isolate is only valid for start.");
-                return -EINVAL;
-        }
+        if (mode == JOB_ISOLATE && type != JOB_START)
+                return sd_bus_error_setf(e, SD_BUS_ERROR_INVALID_ARGS, "Isolate is only valid for start.");
 
-        if (mode == JOB_ISOLATE && !unit->allow_isolate) {
-                sd_bus_error_setf(e, BUS_ERROR_NO_ISOLATION, "Operation refused, unit may not be isolated.");
-                return -EPERM;
-        }
+        if (mode == JOB_ISOLATE && !unit->allow_isolate)
+                return sd_bus_error_setf(e, BUS_ERROR_NO_ISOLATION, "Operation refused, unit may not be isolated.");
 
         log_debug_unit(unit->id,
                        "Trying to enqueue job %s/%s/%s", unit->id,
diff --git a/src/core/transaction.c b/src/core/transaction.c
index dbb4133fe3..488cb86fe4 100644
--- a/src/core/transaction.c
+++ b/src/core/transaction.c
@@ -264,13 +264,12 @@ static int transaction_merge_jobs(Transaction *tr, sd_bus_error *e) {
                                 return -EAGAIN;
 
                         /* We couldn't merge anything. Failure */
-                        sd_bus_error_setf(e, BUS_ERROR_TRANSACTION_JOBS_CONFLICTING,
-                                          "Transaction contains conflicting jobs '%s' and '%s' for %s. "
-                                          "Probably contradicting requirement dependencies configured.",
-                                          job_type_to_string(t),
-                                          job_type_to_string(k->type),
-                                          k->unit->id);
-                        return r;
+                        return sd_bus_error_setf(e, BUS_ERROR_TRANSACTION_JOBS_CONFLICTING,
+                                                 "Transaction contains conflicting jobs '%s' and '%s' for %s. "
+                                                 "Probably contradicting requirement dependencies configured.",
+                                                 job_type_to_string(t),
+                                                 job_type_to_string(k->type),
+                                                 k->unit->id);
                 }
         }
 
@@ -412,9 +411,8 @@ static int transaction_verify_order_one(Transaction *tr, Job *j, Job *from, unsi
 
                 log_error("Unable to break cycle");
 
-                sd_bus_error_setf(e, BUS_ERROR_TRANSACTION_ORDER_IS_CYCLIC,
-                                  "Transaction order is cyclic. See system logs for details.");
-                return -ENOEXEC;
+                return sd_bus_error_setf(e, BUS_ERROR_TRANSACTION_ORDER_IS_CYCLIC,
+                                         "Transaction order is cyclic. See system logs for details.");
         }
 
         /* Make the marker point to where we come from, so that we can
@@ -513,12 +511,9 @@ static int transaction_is_destructive(Transaction *tr, JobMode mode, sd_bus_erro
                 assert(!j->transaction_next);
 
                 if (j->unit->job && (mode == JOB_FAIL || j->unit->job->irreversible) &&
-                    !job_type_is_superset(j->type, j->unit->job->type)) {
-
-                        sd_bus_error_setf(e, BUS_ERROR_TRANSACTION_IS_DESTRUCTIVE,
-                                          "Transaction is destructive.");
-                        return -EEXIST;
-                }
+                    !job_type_is_superset(j->type, j->unit->job->type))
+                        return sd_bus_error_setf(e, BUS_ERROR_TRANSACTION_IS_DESTRUCTIVE,
+                                                 "Transaction is destructive.");
         }
 
         return 0;
@@ -860,50 +855,39 @@ int transaction_add_job_and_dependencies(
         /*           by ? by->unit->id : "NA", */
         /*           by ? job_type_to_string(by->type) : "NA"); */
 
-        if (unit->load_state != UNIT_LOADED &&
-            unit->load_state != UNIT_ERROR &&
-            unit->load_state != UNIT_NOT_FOUND &&
-            unit->load_state != UNIT_MASKED) {
-                sd_bus_error_setf(e, BUS_ERROR_LOAD_FAILED,
-                                  "Unit %s is not loaded properly.", unit->id);
-                return -EINVAL;
-        }
+        if (!IN_SET(unit->load_state, UNIT_LOADED, UNIT_ERROR, UNIT_NOT_FOUND, UNIT_MASKED))
+                return sd_bus_error_setf(e, BUS_ERROR_LOAD_FAILED,
+                                         "Unit %s is not loaded properly.", unit->id);
 
         if (type != JOB_STOP && unit->load_state == UNIT_ERROR) {
                 if (unit->load_error == -ENOENT || unit->manager->test_run)
-                        sd_bus_error_setf(e, BUS_ERROR_LOAD_FAILED,
-                                          "Unit %s failed to load: %s.",
-                                          unit->id,
-                                          strerror(-unit->load_error));
+                        return sd_bus_error_setf(e, BUS_ERROR_LOAD_FAILED,
+                                                 "Unit %s failed to load: %s.",
+                                                 unit->id,
+                                                 strerror(-unit->load_error));
                 else
-                        sd_bus_error_setf(e, BUS_ERROR_LOAD_FAILED,
-                                          "Unit %s failed to load: %s. "
-                                          "See system logs and 'systemctl status %s' for details.",
-                                          unit->id,
-                                          strerror(-unit->load_error),
-                                          unit->id);
-                return -EINVAL;
+                        return sd_bus_error_setf(e, BUS_ERROR_LOAD_FAILED,
+                                                 "Unit %s failed to load: %s. "
+                                                 "See system logs and 'systemctl status %s' for details.",
+                                                 unit->id,
+                                                 strerror(-unit->load_error),
+                                                 unit->id);
         }
 
-        if (type != JOB_STOP && unit->load_state == UNIT_NOT_FOUND) {
-                sd_bus_error_setf(e, BUS_ERROR_LOAD_FAILED,
-                                  "Unit %s failed to load: %s.",
-                                  unit->id, strerror(-unit->load_error));
-                return -EINVAL;
-        }
+        if (type != JOB_STOP && unit->load_state == UNIT_NOT_FOUND)
+                return sd_bus_error_setf(e, BUS_ERROR_LOAD_FAILED,
+                                         "Unit %s failed to load: %s.",
+                                         unit->id, strerror(-unit->load_error));
 
-        if (type != JOB_STOP && unit->load_state == UNIT_MASKED) {
-                sd_bus_error_setf(e, BUS_ERROR_UNIT_MASKED,
-                                  "Unit %s is masked.", unit->id);
-                return -EADDRNOTAVAIL;
-        }
+        if (type != JOB_STOP && unit->load_state == UNIT_MASKED)
+                return sd_bus_error_setf(e, BUS_ERROR_UNIT_MASKED,
+                                         "Unit %s is masked.", unit->id);
+
+        if (!unit_job_is_applicable(unit, type))
+                return sd_bus_error_setf(e, BUS_ERROR_JOB_TYPE_NOT_APPLICABLE,
+                                         "Job type %s is not applicable for unit %s.",
+                                         job_type_to_string(type), unit->id);
 
-        if (!unit_job_is_applicable(unit, type)) {
-                sd_bus_error_setf(e, BUS_ERROR_JOB_TYPE_NOT_APPLICABLE,
-                                  "Job type %s is not applicable for unit %s.",
-                                  job_type_to_string(type), unit->id);
-                return -EBADR;
-        }
 
         /* First add the job. */
         ret = transaction_add_one_job(tr, type, unit, override, &is_new);
diff --git a/src/core/unit.c b/src/core/unit.c
index 84f210a312..d5acc728ec 100644
--- a/src/core/unit.c
+++ b/src/core/unit.c
@@ -2939,18 +2939,16 @@ int unit_kill_common(
 
         if (who == KILL_MAIN && main_pid <= 0) {
                 if (main_pid < 0)
-                        sd_bus_error_setf(error, BUS_ERROR_NO_SUCH_PROCESS, "%s units have no main processes", unit_type_to_string(u->type));
+                        return sd_bus_error_setf(error, BUS_ERROR_NO_SUCH_PROCESS, "%s units have no main processes", unit_type_to_string(u->type));
                 else
-                        sd_bus_error_set_const(error, BUS_ERROR_NO_SUCH_PROCESS, "No main process to kill");
-                return -ESRCH;
+                        return sd_bus_error_set_const(error, BUS_ERROR_NO_SUCH_PROCESS, "No main process to kill");
         }
 
         if (who == KILL_CONTROL && control_pid <= 0) {
                 if (control_pid < 0)
-                        sd_bus_error_setf(error, BUS_ERROR_NO_SUCH_PROCESS, "%s units have no control processes", unit_type_to_string(u->type));
+                        return sd_bus_error_setf(error, BUS_ERROR_NO_SUCH_PROCESS, "%s units have no control processes", unit_type_to_string(u->type));
                 else
-                        sd_bus_error_set_const(error, BUS_ERROR_NO_SUCH_PROCESS, "No control process to kill");
-                return -ESRCH;
+                        return sd_bus_error_set_const(error, BUS_ERROR_NO_SUCH_PROCESS, "No control process to kill");
         }
 
         if (who == KILL_CONTROL || who == KILL_ALL)