diff options
| author | Michal Sekletar <msekleta@redhat.com> | 2015-09-01 16:02:58 +0200 |
|---|---|---|
| committer | Michal Sekletar <msekleta@redhat.com> | 2015-09-01 17:09:56 +0200 |
| commit | 24154879845c6aa68a82d3a606f037e9df7527e0 (patch) | |
| tree | 0812a444a258cbc63adbf6e83452918611987358 /src/core | |
| parent | 3f010fe095a8070299d35f0f9d386672e0cb2af0 (diff) | |
selinux: always use *_raw API from libselinux
When mcstransd* is running non-raw functions will return translated SELinux
context. Problem is that libselinux will cache this information and in the
future it will return same context even though mcstransd maybe not running at
that time. If you then check with such context against SELinux policy then
selinux_check_access may fail depending on whether mcstransd is running or not.
To workaround this problem/bug in libselinux, we should always get raw context
instead. Most users will not notice because result of access check is logged
only in debug mode.
* SELinux context translation service, which will translates labels to human
readable form
Diffstat (limited to 'src/core')
| -rw-r--r-- | src/core/selinux-access.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/core/selinux-access.c b/src/core/selinux-access.c index f920c2e2cd..40ca0c6166 100644 --- a/src/core/selinux-access.c +++ b/src/core/selinux-access.c @@ -246,7 +246,7 @@ int mac_selinux_generic_access_check( if (path) { /* Get the file context of the unit file */ - r = getfilecon(path, &fcon); + r = getfilecon_raw(path, &fcon); if (r < 0) { r = sd_bus_error_setf(error, SD_BUS_ERROR_ACCESS_DENIED, "Failed to get file context on %s.", path); goto finish; @@ -254,7 +254,7 @@ int mac_selinux_generic_access_check( tclass = "service"; } else { - r = getcon(&fcon); + r = getcon_raw(&fcon); if (r < 0) { r = sd_bus_error_setf(error, SD_BUS_ERROR_ACCESS_DENIED, "Failed to get current context."); goto finish; |